Add support for AzureMfaAuthentication#124
Merged
venth merged 1 commit intoventh:masterfrom Jul 11, 2019
Merged
Conversation
Owner
|
Sorry, but until Wednesday next week I’m unable to proceed with this PR. My computer has issues with its keyboard and I passed it to apple service. Unfortunately replacing the keyboard takes one week or more 😞😭 |
venth
approved these changes
Jul 11, 2019
Owner
|
released with version 1.17.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for AzureMfaAuthentication AuthMethod that is used in the Azure MFA SAAS/Cloud version.
It is based on the _azure_mfa_authenticator code (that supports the AzureServerMfaAuthentication AuthMethod). Instead, this code polls every five seconds (up to max 60) until it gets a valid SAMLResponse.
It is tested to work along with push notifications to the Microsoft Authenticator app for approval.