Default to 'default' profile, in line with other AWS tools.#14
Merged
venth merged 1 commit intoventh:masterfrom Nov 5, 2016
brandond:use-default-profile
Merged
Default to 'default' profile, in line with other AWS tools.#14venth merged 1 commit intoventh:masterfrom brandond:use-default-profile
venth merged 1 commit intoventh:masterfrom
brandond:use-default-profile
Conversation
Contributor
Author
|
Actually, let me take a longer look at this. I think I can probably replace a lot of the current |
Owner
|
I'm OK with the change. It makes sense to stick to aws cli behavior. I'll be little unresponsive. I've caught sinusitis. |
Contributor
Author
|
Ahh that sucks, hope you feel better soon :( I'll comment again when I have something ready for review. |
Owner
|
OK |
Owner
|
Hi @brandond, do you want me to merge this request? |
This might be a breaking change for some folks, but I think it's important to work the same as other AWS CLI tools that all work with the 'default' profile if the --profile option or AWS_DEFAULT_PROFILE environment variable are not set.
Contributor
Author
|
@venth go ahead and take it as-is; I still might take a shot at centralizing the config load/store stuff into one place, but I don't have the time for it at the moment. I'll open a new PR when I do. |
Owner
|
merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be a breaking change for some folks, but I think it's important to work the same as other AWS CLI tools that all work with the 'default' profile if the --profile option or AWS_DEFAULT_PROFILE environment variable are not set.
This change also makes it honor the AWS_DEFAULT_PROFILE environment variable, which it does not currently do.