Skip to content

Improve handling of errors caused by excessive cookie growth.#15

Merged
venth merged 1 commit intoventh:masterfrom
brandond:fix-headers-too-long
Oct 11, 2016
Merged

Improve handling of errors caused by excessive cookie growth.#15
venth merged 1 commit intoventh:masterfrom
brandond:fix-headers-too-long

Conversation

@brandond
Copy link
Contributor

@brandond brandond commented Oct 10, 2016

ADFS appends a GUID to the SAMLSession cookie value every time it is used; eventually this will exceed the max header size since we don't ever clear it out. Error looks something like this:

`<TITLE>Bad Request</TITLE>

Bad Request - Request Too Long


HTTP Error 400. The size of the request headers is too long.

`

Work around this by:

  • Not loading session cookies whenever we are re-authenticating with credentials
  • Clearing all cookies if the server throws an error

@venth venth merged commit e500478 into venth:master Oct 11, 2016
@brandond brandond deleted the fix-headers-too-long branch October 12, 2016 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants