Add support for legacy aws_security_token key in credentials file#3
Merged
venth merged 1 commit intoventh:masterfrom Jul 10, 2016
brandond:add_boto_compat
Merged
Add support for legacy aws_security_token key in credentials file#3venth merged 1 commit intoventh:masterfrom brandond:add_boto_compat
venth merged 1 commit intoventh:masterfrom
brandond:add_boto_compat
Conversation
Ansible uses a weird hybrid of boto and boto3 that [doesn't appear to properly support the new AWS_SESSION_TOKEN variable](boto/boto#3298), and instead still looks for AWS_SECURITY_TOKEN. This patch is a monkeypatch for this issue that updates aws-adfs to write the token into the credentials file under both keys.
Contributor
Author
|
This one's pretty minor, but I need it for Ansible support - since a majority of the Ansible AWS modules haven't been upgraded to boto3, and the aforementioned issue with boto has not been fixed. |
Owner
|
Small indeed 😀 If it would work for ansible, it'll be awesome. Till now I use nasty decorator hack that adds additional header containing session token for every boto call. I'll merge it now. New package I could upload once I'll be back home from a walk with my son 😄 Thanks again. |
Owner
|
Released ;) Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ansible uses a weird hybrid of boto and boto3 that doesn't appear to properly support the new AWS_SESSION_TOKEN variable, and instead still looks for AWS_SECURITY_TOKEN. This patch is a monkeypatch for this issue that updates aws-adfs to write the token into the credentials file under both keys.