Merged
Conversation
venth
reviewed
Apr 8, 2018
Owner
venth
left a comment
venth
left a comment
There was a problem hiding this comment.
Would you like to consider usage of limited number of repetition instead of while true?
Contributor
Author
|
No problem, I'll add a limit shortly! Thanks! |
Example Output when limit reduced:
```
$ aws-adfs login --adfs-host=sso.zefr.com
Sending request for authentication
Waiting for additional authentication
Error: There was an issue during sending code to the device. The responses: ['{"response": {"status_code": "calling", "status": "Calling your phone..."}, "stat": "OK"}', '{"response": {"status_code": "calling", "status": "Dialing XXX-XXX-1231...", "msg_info": {"number": "XXX-XXX-1231"}}, "stat": "OK"}']
```
Contributor
Author
|
I decided to save the response.text if it loops to many times for the error. Example Output when limit reduced: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app would crash when calling a phone.