get_status: Flatten input before sending requests#6
Merged
venthur merged 1 commit intoventhur:masterfrom Aug 12, 2015
jamessan:status-perf
Merged
get_status: Flatten input before sending requests#6venthur merged 1 commit intoventhur:masterfrom jamessan:status-perf
venthur merged 1 commit intoventhur:masterfrom
jamessan:status-perf
Conversation
aca7ac2 introduced a performance regression (as reported in Debian bug #795198) for typical inputs, since every bug's status would be requested individually. Flattening the input to a single list before performing the batch requests ensures we're not performing unnecessary requests. Signed-off-by: James McCoy <jamessan@debian.org>
Owner
|
Thank you very much for your patch! I've applied it with a minor modification: I renamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aca7ac2 introduced a performance
regression (as reported in Debian bug #795198) for typical inputs, since
every bug's status would be requested individually.
Flattening the input to a single list before performing the batch
requests ensures we're not performing unnecessary requests.
Signed-off-by: James McCoy jamessan@debian.org