fix: suppress urllib3 debug logging by default (closes #144)#146
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
fix: suppress urllib3 debug logging by default (closes #144)#146botbikamordehai2-sketch wants to merge 1 commit into
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a user configures their application's root logger at DEBUG level, they unexpectedly receive DEBUG messages from
urllib3(used internally byrequests) such as:These messages originate from
urllib3's own logger and propagate to the root logger, cluttering application logs.Fix
Set the
urllib3logger level toWARNINGin theAPI.__init__method so that internal HTTP connection details are suppressed by default. Users who want these messages can re-enable them by adjustinglogging.getLogger('urllib3').setLevel(logging.DEBUG)in their own code.Closes #144