45#46
Open
vepretski wants to merge 1502 commits into
Open
Conversation
…malyco#30905) Co-authored-by: Shoubhit Dash <shoubhit2005@gmail.com>
References, MCP timeouts, Anthropic fallback fixes, desktop session flow improvements.
…dle status always published after loop exit - Removed PRAGMA wal_checkpoint(PASSIVE) and auto_vacuum=INCREMENTAL from database.ts. On a 12GB DB, PASSIVE checkpoint blocks for minutes. SQLite WAL mode checkpoints automatically in background. auto_vacuum can be set when DB is first created. - Added Effect.ensuring to runLoop that always publishes session idle status after the loop exits (with 100ms delay for event propagation). Previously if lastAssistant() or cleanup threw, the idle status was never published, leaving the TUI spinner running forever.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Open
discoart
force-pushed
the
dev
branch
3 times, most recently
from
09c61a2 to
fbfda61
Compare
…acuum The upstream merge reverted previous performance fixes: - wal_checkpoint(PASSIVE) blocks startup 5-10min on large databases - auto_vacuum = INCREMENTAL was not in upstream Both are removed to restore fast startup.
Removes Sentry (desktop, app packages), OpenTelemetry (core, opencode), and PostHog (scripts). All three were gated behind env variables so never active in the fork, but this eliminates the code entirely: - Sentry: init blocks, captureException calls, vite plugins, deps, env.d.ts - OpenTelemetry: observability module (otlp, shared, logging), OTEL flag, experimental.openTelemetry config, tracer usage in llm.ts/agent.ts, OTEL env passthrough in workspace.ts, OTel deps from package.json - PostHog: sendToPostHog function and download stats calls in script/stats.ts - Generated SDK types: openTelemetry boolean removed from type definitions - Tests: OTEL env var setup/teardown/assertions removed
observability.ts still imported Otlp for loggers() and tracingLayer(), and otlp.ts was replaced with a circular self-re-export. This broke startup with 'Otlp.loggers is not a function'. Fix: Remove Otlp from observability.ts (keep only Logging), and restore otlp.ts with no-op loggers() and tracingLayer() exports.
- runner/prompt/processor: Effect.catchAll → Effect.catch for effect v4 - processor: O(N²) text/reasoning delta accumulation → O(N) chunks - processor: remove guard that dropped non-error tool results with no call - task: runCancel.fork → runCancel.run (cancel was being scheduled, not executed) - run-state: guard against concurrent runner creation for same sessionID - compaction: NPE guard for empty messages array - message-v2: NPE guard for undefined tool output - prompt: orphan detection uses time.created instead of id - prompt: fix if/else if structure for tool part result - build-switch: add re-read reminder on plan→build switch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Type of change
Validation
Checklist
Notes for reviewers