Define initial class for EAR claimset along with its unit test, setup tox for testing#3
Merged
Merged
Conversation
Signed-off-by: HarshvMahawar <hv062727@gmail.com>
HarshvMahawar
force-pushed
the
EAR-structure
branch
3 times, most recently
from
789c27e to
1420437
Compare
THS-on
reviewed
Mar 1, 2025
| @@ -0,0 +1,26 @@ | |||
| # Byte-compiled and cache files | |||
Member
There was a problem hiding this comment.
You are currently also committing *.pyc files. Consider using the following .gitignore: https://github.com/github/gitignore/blob/main/Python.gitignore
|
|
||
|
|
||
| class EARClaims: | ||
| def __init__( |
Member
There was a problem hiding this comment.
Have a look at dataclasses, no need to write then a lot of things yourself.
Collaborator
Author
There was a problem hiding this comment.
ya, dataclasses feature is really good! i will add it asap
| ## Linting and static analysis | ||
|
|
||
| 1. [flake8](https://pypi.org/project/flake8/) | ||
| 2. [mypy](https://pypi.org/project/mypy/) |
Member
There was a problem hiding this comment.
Also take a look at pyright and pylint
Collaborator
Author
There was a problem hiding this comment.
yes, I have added those in the tests as well
HarshvMahawar
force-pushed
the
EAR-structure
branch
from
1420437 to
f3665f0
Compare
… tox for testing Signed-off-by: HarshvMahawar <hv062727@gmail.com>
HarshvMahawar
force-pushed
the
EAR-structure
branch
from
f3665f0 to
cde8437
Compare
Signed-off-by: HarshvMahawar <hv062727@gmail.com>
THS-on
reviewed
Mar 3, 2025
Member
There was a problem hiding this comment.
This folder should not be in the repo
Signed-off-by: HarshvMahawar <hv062727@gmail.com>
HarshvMahawar
force-pushed
the
EAR-structure
branch
from
a289541 to
853711b
Compare
THS-on
approved these changes
Mar 3, 2025
Member
|
Can you squash the commits together and then merge it? |
Collaborator
Author
|
thanks @thomas-fossati for merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defined initial class definition of EAR claimset and also set the tox environment for testing of the library