Usability improvements and clippy/fmt fixes
#42
Merged
+209
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the following traits for TrustTier to make it easier to convert between it and primitive types: TryFrom<&str> TryFrom<i8> From<TrustTier> for String From<TrustTier> for i8 From<&TrustTier> for &str From<&TrustTier> for i8 Serialization/deserialization code is also simplified using these traits. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
This allows instantiating literal Bytes with
Bytes(vec![...])
Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
Implement ToString for RawValue to allow it to be Displayed. This also mean implementing ToString for Bytes (as it's one the variants of RawValue). Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
Implement the Debug trait for TrustClaim, rather than deriving implementation. Derived implementation included all the fields in the output, including the long-form description, which resulted in difficult to parse output when looking at multiple claims (e.g. a TrustVector). Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
- Replace ToString implementations with Display. - Remove unnecessary to_string()'s in format arguments. - Simplify some returns by removing unnecessary return's and Ok() wrappers. - Layout according to fmt. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
As per Dependabot: - update checkout action to v5 - update thiserror create to v2 Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrustTierByte's inner values to allow for literal instatiationsBytesandRawValueDebugimplementation forTrustClaimthat is more readable than the derived oneclippyandfmtfixes.