fix: respect allowFileModifications setting in remove command#8
Merged
Conversation
## Summary The remove command was not respecting the `allowFileModifications` setting in `opensrc/package.json`, causing it to always update AGENTS.md even when file modifications were disabled. This fix aligns the remove command's behavior with the fetch command. ## Changes - Added import for `getFileModificationPermission` from settings module - Added import for `updatePackageIndex` from agents module - Added permission check before updating AGENTS.md - When file modifications are disabled, only update the package index instead of AGENTS.md - Preserved existing console output behavior when file modifications are allowed Fixes #6
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The remove command was not respecting the
allowFileModificationssetting inopensrc/package.json, causing it to always update AGENTS.md even when file modifications were disabled. This fix aligns the remove command's behavior with the fetch command.Changes
getFileModificationPermissionfrom settings moduleupdatePackageIndexfrom agents moduleFixes #6