fix: portable signalExitCode via os.constants.signals#23
Open
rohitg00 wants to merge 1 commit into
Open
Conversation
The hardcoded signal map used Linux signal numbers (SIGBUS=7), which is wrong on Darwin where SIGBUS=10. Subprocesses terminated by signal would exit with the wrong code on macOS. Use os.constants.signals so each host reports the right number.
|
@rohitg00 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signalExitCodeinscripts/zero-cli.mjshardcoded a signal-number map using Linux values (e.g.SIGBUS: 7). On Darwin those numbers differ —SIGBUSis10, not7— so a native compiler crash terminated by signal reports the wrong exit code on macOS.Node already exposes the correct per-platform values via
os.constants.signals. This swap removes the hardcoded table and gets each host's actual numbers.Test plan
node -e "console.log(128 + require('os').constants.signals.SIGBUS)"returns138on Darwin (was135with old table)node -e "console.log(128 + require('os').constants.signals.SIGSEGV)"returns139on both platformsnpm run docs:testpasses?? 1) preserved