Fix absolute element scope to button.#23
Merged
haydenbleasel merged 1 commit intovercel:mainfrom Aug 21, 2025
Merged
Conversation
…snt cause extra scrollbars
When using the Actions component there's an added sr-only class for screenreaders, however this adds a
```
.sr-only{position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
clip: rect(0, 0, 0, 0);
white-space: nowrap;
border-width: 0;}```
which causes an extra scrollbar to appear. adding relative to the Button, makes sure the position absolute is scoped to the Button and not the parent container
Contributor
|
@KrisTemmerman is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Moskuz
approved these changes
Aug 20, 2025
Contributor
|
Nice find! Thanks @KrisTemmerman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Actions component applies a sr-only class for screen reader accessibility, but this causes an unintended side effect where a double scrollbar appears on the page.
Root cause:
The sr-only class uses position: absolute without a positioned parent container, causing the absolutely positioned element to be positioned relative to the document body or a distant ancestor, which triggers overflow and creates the extra scrollbar.
Add
position: relativeto the Button component to establish a proper positioning context. This ensures the sr-only element is positioned relative to the Button itself rather than escaping to a parent container.