Fix #398: Support additional icon libraries (similar to shadcn/ui)?#424
Open
JiwaniZakir wants to merge 1 commit intovercel:mainfrom
Open
Fix #398: Support additional icon libraries (similar to shadcn/ui)?#424JiwaniZakir wants to merge 1 commit intovercel:mainfrom
JiwaniZakir wants to merge 1 commit intovercel:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
@JiwaniZakir is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #398
Replaces the
LucideIcon/LucidePropstype constraints with generic React component types so callers can pass icons from any library — Tabler, Phosphor, Hugeicons, Remix, etc. — not just Lucide. The change is purely a type-level loosening; no runtime behavior changes.artifact.tsx—ArtifactActionProps.iconchanged fromLucideIcontoComponentType<{ className?: string }>chain-of-thought.tsx—ChainOfThoughtStepProps.iconchanged fromLucideIcontoComponentType<{ className?: string }>checkpoint.tsx—CheckpointIconPropschanged fromLucidePropstoSVGProps<SVGSVGElement>Verified by passing a Tabler icon (
IconBrainfrom@tabler/icons-react) and a Phosphor icon (Brainfromphosphor-react) intoChainOfThoughtStepandArtifactActionrespectively — both rendered correctly with no TypeScript errors.This PR was created with AI assistance (Claude). The changes were reviewed by quality gates and a critic model before submission.