fix(provider): fix v4 spec to not use shared v3 types#13482
Merged
Conversation
Collaborator
Author
|
@aayush-kapoor @gr2m The CI failure here is unrelated to these changes, likely occurring due to the addition of Node 24 in CI, see #13358. I believe it's a test instability, so maybe that's why it worked upon merge of that PR, but now it's causing failures. See #13483 |
lgrammel
approved these changes
Mar 16, 2026
Contributor
|
🚀 Published in:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The v4 language model spec types were incorrectly importing and using shared v3 types (
SharedV3ProviderOptions,SharedV3ProviderMetadata,SharedV3Headers,SharedV3Warning) instead of their v4 equivalents. This meant the v4 spec was not self-contained and depended on v3 shared types.Initially pointed out by @lgrammel in #13352 (comment).
Summary
Updated all v4 language model spec files to import from
shared/v4instead ofshared/v3, using the correctSharedV4*types throughout.Manual Verification
N/A — type-only change, verified by successful build/type-check.
Checklist
pnpm changesetin the project root)Future Work
N/A
Related Issues
N/A