fix(amazon-bedrock): preserve ARN model IDs unencoded in URL paths#14257
Open
giulio-leone wants to merge 1 commit into
Open
fix(amazon-bedrock): preserve ARN model IDs unencoded in URL paths#14257giulio-leone wants to merge 1 commit into
giulio-leone wants to merge 1 commit into
Conversation
Inference-profile ARNs (e.g. arn:aws:bedrock:us-east-1:123456789012:application-inference-profile/abc) were broken by encodeURIComponent encoding colons and slashes. The Bedrock REST API requires the literal ARN in the path segment. Introduce bedrockEncodeModelId() that skips encoding for arn: prefixed IDs while preserving existing percent-encoding for regular model IDs. Applied in all four getUrl / buildRequestUrl call sites: - bedrock-chat-language-model.ts - bedrock-embedding-model.ts - bedrock-image-model.ts - anthropic/bedrock-anthropic-provider.ts Fixes vercel#14117 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14117
encodeURIComponent(modelId)breaks inference-profile ARNs because it encodes:→%3Aand/→%2F, producing an invalid URL that Bedrock rejects with "The provided model identifier is invalid".Changes
bedrockEncodeModelId(modelId)— returns the raw ARN whenmodelIdstarts witharn:, otherwise falls back toencodeURIComponent.getUrl/buildRequestUrlcall sites:bedrock-chat-language-model.tsbedrock-embedding-model.tsbedrock-image-model.tsanthropic/bedrock-anthropic-provider.tsbedrock-encode-model-id.test.ts(5 cases: standard model IDs, application-inference-profile ARNs, cross-region inference-profile ARNs, non-ARN colons, plain IDs).Before / After
us.amazon.nova-2-lite-v1:0.../model/us.amazon.nova-2-lite-v1%3A0✅.../model/us.amazon.nova-2-lite-v1%3A0✅arn:aws:bedrock:us-east-1:123456789012:application-inference-profile/abc.../model/arn%3Aaws%3A...❌.../model/arn:aws:bedrock:us-east-1:123456789012:application-inference-profile/abc✅