refactoring: executeTool uses tool as parameter#14516
Merged
Conversation
tigent
Bot
added
ai/core
lgrammel
commented
Apr 16, 2026
| execute: tool.execute!.bind(tool), | ||
| input, | ||
| tool, | ||
| input: input as InferToolInput<typeof tool>, |
Collaborator
Author
There was a problem hiding this comment.
result of tightening the types on executeTool
lgrammel
commented
Apr 16, 2026
| messages, | ||
| abortSignal: toolAbortSignal, | ||
| context, | ||
| context: context as InferToolContext<typeof tool>, |
Collaborator
Author
There was a problem hiding this comment.
result of tightening the types on executeTool
nicoalbanese
approved these changes
Apr 16, 2026
Contributor
|
🚀 Published in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
executeToolin provider utils was working on the execute function level. This lead to having to pushbindintoexecuteToolCalland weakened type checking since any input, context etc could be sent.Summary
executeToolworks on a tool level with tighter type validationExecutableTooltype andisExecutableToolhelper for type narrowingRelated Work
Discovered during #14515