feat(ai): remove telemetry data from the user-facing event data#14606
Merged
aayush-kapoor merged 17 commits intomainfrom Apr 21, 2026
Merged
feat(ai): remove telemetry data from the user-facing event data#14606aayush-kapoor merged 17 commits intomainfrom
aayush-kapoor merged 17 commits intomainfrom
Conversation
tigent
Bot
added
ai/core
aayush-kapoor
commented
Apr 17, 2026
aayush-kapoor
commented
Apr 17, 2026
lgrammel
reviewed
Apr 20, 2026
lgrammel
reviewed
Apr 20, 2026
lgrammel
reviewed
Apr 20, 2026
lgrammel
reviewed
Apr 20, 2026
lgrammel
reviewed
Apr 20, 2026
lgrammel
reviewed
Apr 20, 2026
lgrammel
reviewed
Apr 20, 2026
lgrammel
reviewed
Apr 20, 2026
|
|
||
| export type TelemetryEvent<EVENT> = EVENT & TelemetryMetadata; | ||
|
|
||
| type OperationStartEvent = |
Collaborator
There was a problem hiding this comment.
wonder if separate event handlers would be better. otherwise we need event type ids.
lgrammel
reviewed
Apr 21, 2026
lgrammel
reviewed
Apr 21, 2026
lgrammel
approved these changes
Apr 21, 2026
This was referenced Apr 21, 2026
aayush-kapoor
added a commit
that referenced
this pull request
Apr 23, 2026
## Background as a follow up to the PR #14654 and #14606, we had to continue removing and aligning the event data sent at each callback in the lifecycle ## Summary - `prompt` property removed and `StandardizedPrompt` used instead - `stepNumber` removed and made to derive from the `steps` - `interface` -> `type` used - properties that have overlap with `langaugeModelCallOptions` were stripped and made to use that type ## Manual Verification na ## Checklist - [x] Tests have been added / updated (for bug fixes / features) - [ ] Documentation has been added / updated (for bug fixes / features) - [x] A _patch_ changeset for relevant packages has been added (for bug fixes / features - run `pnpm changeset` in the project root) - [x] I have reviewed this pull request (self-review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We were passing telemetry options/data to every core event which was not needed (at least not for the user facing events)
Summary
Changed it so that the telemetry data is passed when unifying user facing callbacks with the provider facing ones so that provider implementations of
Telemetryinterface still get all the information.This is verified by some tests breaking in
aiand no tests breaking inotel/devtoolspackageManual Verification
verified by running the example
examples/ai-functions/src/generate-text/anthropic/subagent-with-telemetry.ts- the functionID defined in this example is still observed in the final traceChecklist
pnpm changesetin the project root)Future Work
type: event-typeproperty to core-events