fix(ai): return validated elements from array output parseCompleteOutput#15734
Merged
lgrammel merged 1 commit intoJun 5, 2026
Merged
Conversation
7730c20 to
e04d975
Compare
e04d975 to
f32926b
Compare
lgrammel
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When using
generateTextwithoutput: Output.array(...), theparseCompleteOutputmethod validated each element withsafeValidateTypesbut discardedvalidationResult.value, returning the raw parsed JSON (outerValue.elements) instead. This silently dropped any schema transforms (.transform()), coercions (.coerce), and defaults (.default()), causing the TypeScript return typeArray<ELEMENT>to be incorrect at runtime.Summary
validationResult.valueduring the validation loop and return the validated array instead ofouterValue.elementsas Array<ELEMENT>type assertion.transform()schema that proves returned values come from validation, not raw JSONManual Verification
Ran the
output.test.tstest suite — all 62 tests pass, including the new transform test which would fail on the old code (it would return{ content: "hello" }instead of{ content: "hello", extra: true }).Checklist
pnpm changesetin the project root)Related Issues
Fixes #15708