doc: fix broken video embed in MLflow observability docs#15924
Closed
narutamaaurum wants to merge 2 commits into
Closed
doc: fix broken video embed in MLflow observability docs#15924narutamaaurum wants to merge 2 commits into
narutamaaurum wants to merge 2 commits into
Conversation
Update v5 branch references to main in middleware documentation. Fixes vercel#12617
Replace video embed (which renders as broken link) with a direct link to the video. Fixes vercel#12472
1 task
pull Bot
pushed a commit
to edisplay/ai
that referenced
this pull request
Jun 30, 2026
## Background The MLflow observability page used Markdown image syntax for an `.mp4` asset: ```md  ``` That produces an image element, so the browser renders the hero media as a broken image even though the asset itself returns `200 OK` with `content-type: video/mp4`. I compared the two open PRs for vercel#12472: - vercel#12677 has the correct approach: render the MP4 as an HTML `<video>` element. It is stale because it edits the old `content/providers/05-observability/mlflow.mdx` path. - vercel#15924 correctly identifies the broken Markdown image embed and includes the useful idea of preserving a direct link, but it changes the hero media to a plain link and includes unrelated middleware documentation changes. ## Summary This updates the current MLflow observability page at `content/providers/03-observability/mlflow.mdx` to render the MP4 with a `<video>` element. The video keeps controls, uses `muted` for reliable autoplay, loops like a hero demo, and includes a fallback link inside the element. ## Checklist - [x] All commits are signed (PRs with unsigned commits cannot be merged) - [ ] Tests have been added / updated (for bug fixes / features) - [x] Documentation has been added / updated (for bug fixes / features) - [ ] A _patch_ changeset for relevant packages has been added (for bug fixes / features - run `pnpm changeset` in the project root) - [x] I have reviewed this pull request (self-review) ## Related Issues Fixes vercel#12472. Supersedes and closes vercel#12677. Supersedes and closes vercel#15924. Co-authored-by: Shurik <shurik@openclaw.ai> Co-authored-by: Narutama Aurum <narutamaaurum@gmail.com> Co-authored-by: Narutama Aurum <narutamaaurum@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The video embed in the MLflow observability documentation was rendering as a broken link on the website. The MP4 video file exists and is accessible, but markdown image syntax () creates an tag which cannot play MP4 videos.
Changed the embed to a direct link so users can click to view the video.
Fixes #12472