fix: Message annotations are compatible for any message type#959
Merged
MaxLeiter merged 18 commits intovercel:mainfrom Feb 9, 2024
Merged
fix: Message annotations are compatible for any message type#959MaxLeiter merged 18 commits intovercel:mainfrom
MaxLeiter merged 18 commits intovercel:mainfrom
Conversation
adding onEvent callback to ai-stream fixing streaming part typo removing onevent adding optional event param to AIStreamParser passing the extra arg in the transformer for event type
…ssage_annotations works for all Message types
nick-inkeep
changed the title
nick-inkeep
changed the title
MaxLeiter
reviewed
Feb 9, 2024
MaxLeiter
reviewed
Feb 9, 2024
Co-authored-by: Max Leiter <maxwell.leiter@gmail.com>
Co-authored-by: Max Leiter <maxwell.leiter@gmail.com>
MaxLeiter
approved these changes
Feb 9, 2024
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few updates/fixes:
self.messageAnnotationsafter stream-part is encoded. Was causing issue whenappendMessageAnnotationwas used outside ofonFinal. Was the root cause of message annotations are repeated #952.function_call, not justtextparse-complex-response.test.tsto account for the abovechat-with-functionspage/route for the openai example