fix(teams): avoid ESM directory import for graph auth provider#121
Open
cipher416 wants to merge 1 commit intovercel:mainfrom
Open
fix(teams): avoid ESM directory import for graph auth provider#121cipher416 wants to merge 1 commit intovercel:mainfrom
cipher416 wants to merge 1 commit intovercel:mainfrom
Conversation
Contributor
|
@cipher416 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113.
Node.js ESM does not support bare directory imports. The Teams adapter compiled output included:
\n- "@microsoft/microsoft-graph-client/authProviders/azureTokenCredentials"\n
which throws ERR_UNSUPPORTED_DIR_IMPORT at runtime.
Change the import to the explicit file path:
\n- "@microsoft/microsoft-graph-client/authProviders/azureTokenCredentials/index.js"\n
Validation:
Also ran: pnpm check / pnpm fix (no changes).