Skip to content

Add save to Prisma#1

Merged
shuding merged 1 commit intomainfrom
shu/5673
May 22, 2023
Merged

Add save to Prisma#1
shuding merged 1 commit intomainfrom
shu/5673

Conversation

@shuding
Copy link
Copy Markdown
Member

@shuding shuding commented May 22, 2023

No description provided.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 11:11am

@shuding shuding marked this pull request as ready for review May 22, 2023 12:35
@shuding shuding merged commit 3b8bb9d into main May 22, 2023
@shuding shuding deleted the shu/5673 branch May 22, 2023 12:35
mattwoodco pushed a commit to mweser/ai-chatbot that referenced this pull request Jun 30, 2024
m9e referenced this pull request in kamiwaza-ai/ai-chatbot Dec 30, 2024
AipengHuang added a commit to AipengHuang/ai-chatbot that referenced this pull request Feb 1, 2025
dancer added a commit that referenced this pull request Sep 19, 2025
DavideGCosta added a commit to DavideGCosta/ai-chatbot that referenced this pull request Nov 26, 2025
walterjordan pushed a commit to walterjordan/ai-chatbot that referenced this pull request Mar 23, 2026
Copy link
Copy Markdown

@kwasham kwasham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERDICT: PASS

Security review summary:

  • Authentication now flows through lib/auth: Clerk sessions are validated on every route, middleware protects non-public paths, and guest sessions are still backed by httpOnly, secure cookies.
  • /api/auth/guest now rejects any redirect that does not begin with /, so the open redirect vulnerability is closed.
  • Environment variables for Clerk are referenced only in .env.example with placeholder values—no credentials leaked.
  • CI status: no checks reported for this branch (please exercise the normal pipeline if needed).

Copy link
Copy Markdown

@kwasham kwasham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAIL: Reviewed the Clerk migration, and the guest endpoint now enforces that starts with and never with , so the open-redirect fix is in place and guest cookies remain httpOnly/secure. However, the Vercel deployment is currently failing (https://vercel.com/kwashams-projects/vercel-ai-chatbot/7iKMHgBdwgnFRsi37Mjo4pkxufJw — ), so the PR cannot be merged while CI is red. Please fix the failing deployment (e.g., supply the required Clerk environment variables or resolve the build error) and rerun CI before I can approve.

Copy link
Copy Markdown

@kwasham kwasham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAIL: Reviewed the Clerk migration and guest endpoint. The new lib/auth returns Clerk-managed sessions with a guest fallback, and /api/auth/guest now enforces that redirectUrl starts with "/" and never //, so the previous open-redirect class is fixed while the guest cookie stays httpOnly/secure. However, the Vercel deployment is still failing (https://vercel.com/kwashams-projects/vercel-ai-chatbot/7iKMHgBdwgnFRsi37Mjo4pkxufJw — npx vercel inspect dpl_7iKMHgBdwgnFRsi37Mjo4pkxufJw --logs), so the CI barrier is red and this cannot be merged until the deployment succeeds. Please resolve the failing build and rerun the checks before I can approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants