No longer rely on system Python for installs of python3 runtime #93
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
trek
requested review from
EndangeredMassa,
Ethan-Arrowood,
TooTallNate and
cb1kenobi
EndangeredMassa
approved these changes
Sep 21, 2023
Contributor
|
Can we also update the readme to not say that it falls back to system python? |
trek
force-pushed
the
trek/zero-859-python-3-bootstrap-error
branch
from
c9420f6 to
f49d88d
Compare
Ethan-Arrowood
approved these changes
Sep 21, 2023
trek
added a commit
that referenced
this pull request
Sep 25, 2023
trek
added a commit
that referenced
this pull request
Sep 25, 2023
Merged
TooTallNate
added a commit
that referenced
this pull request
Dec 19, 2024
* Revert #93. * Revert #99. * Remove Go setup from CI (the test was already previously disabled in #97). * Remove `pkg` (the test was also disabled in #97). * Remove `prebuild` and `postbuild` npm scripts - they do not get invoked with pnpm. * Use `pnpm` in CI. * Update TypeScript to v4.9.3. --- Co-authored-by: Sean Massa <EndangeredMassa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #34 we added Python 3 that would fallback to system Python 3 if it exists. In MacOS 12.3 Apple removed system python.
This PR updates
python3to behave like the other python runtimes by callinginstallPython.See: