fix(release): upload font zip to v$VERSION release tag, not geist@$VERSION#233
Open
truffle-dev wants to merge 1 commit into
Open
fix(release): upload font zip to v$VERSION release tag, not geist@$VERSION#233truffle-dev wants to merge 1 commit into
truffle-dev wants to merge 1 commit into
Conversation
…RSION The release-npm job creates the GitHub release with tag v$VERSION (changesets/action default for a single-package repo since vercel#222), but the 'Upload font zip to GitHub Release' step still references the legacy geist@$VERSION prefix. The upload targets a release that does not exist and fails with 'release not found', leaving the GitHub release without its zip asset. Closes vercel#231.
|
@truffle-dev is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The
release-npmjob's last step targetsgeist@$VERSIONbut the release thatchangesets/actionactually creates is namedv$VERSION. The upload fails withrelease not foundand the GitHub release ships without its font-zip asset, as happened for v1.7.1.One-line fix.
Root cause
In the CI run for the v1.7.1 release (26189437225),
release-npmgot as far as creating the release tag, then exited 1 on the upload:Since the harden-release work in #222,
changesets/action@v1.8.0with the current single-package layout creates the release at tagv$VERSION. The step right above this one already names the zipgeist-font-v$VERSION.zipwith the same prefix, so the two are now aligned. The legacygeist@<version>tag scheme is only present on releases from before #222 (e.g. geist@1.7.0).Downstream impact
v1.7.1 was the liga-regression fix from #221, so the missing zip leaves downstream consumers without the rebuild they need. Among them: the shadcn-ui docs site at https://ui.shadcn.com/docs/forms/react-hook-form#using-usefieldarray is currently shaping JSX spread
{...controllerField}as.{.controllerField}because the served Geist Mono still has theligasubstitution from v1.7.0 (tracked at shadcn-ui/ui#10796, CSS workaround at shadcn-ui/ui#10809).The fix unblocks the next release; the missing v1.7.1 asset can be uploaded separately if desired.
Verification
Exercised on the next merged "Version Packages" PR. Nothing else in CI calls this code path, so there's nothing local to run.
Closes #231.
Refs #225 (the release-tag-ordering question is a separate maintainer call; this PR only addresses the missing asset).