feat: port ncc bundling pipeline to rspack#1304
Open
ScriptedAlchemy wants to merge 11 commits intovercel:mainfrom
Open
feat: port ncc bundling pipeline to rspack#1304ScriptedAlchemy wants to merge 11 commits intovercel:mainfrom
ScriptedAlchemy wants to merge 11 commits intovercel:mainfrom
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
…igration-b0f7 Webpack to rspack migration
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ScriptedAlchemy
changed the title
Update node-gyp to a Python 3.12+/3.13-compatible release so native test-binary builds work reliably in current macOS environments and no local workaround is required. Co-authored-by: Cursor <cursoragent@cursor.com>
Handle both 4-argument and 5-argument watch callback signatures so changed and removed file sets are forwarded correctly and callbackUndelayed receives file metadata. Co-authored-by: Cursor <cursoragent@cursor.com>
styfle
reviewed
Feb 10, 2026
| minify, | ||
| cache, | ||
| v8cache, | ||
| externals: ["@vercel/webpack-asset-relocator-loader"] |
Member
There was a problem hiding this comment.
Why does this dependency need to be external now?
styfle
reviewed
Feb 10, 2026
| let sourceMapText; | ||
| let diagnostics = []; | ||
|
|
||
| module.exports = require("ts-loader"); |
Member
There was a problem hiding this comment.
I see ts-loader is no longer used but its still in package.json
Is that expected?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing