Merged
Conversation
Member
|
@guybedford It looks like CI is failing |
styfle
reviewed
Apr 3, 2019
Contributor
Author
|
Ok looking into it. |
Contributor
Author
|
Ok the test should be working now... the test case was overriding the ncc self-build :P |
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 69.55% 69.37% -0.19%
==========================================
Files 12 12
Lines 381 382 +1
==========================================
Hits 265 265
- Misses 116 117 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the watcher regression in #342, and includes a full end-to-end test of the watching behaviour to avoid any further regressions in future.