Skip to content

Add failing Firebase test#419

Merged
Timer merged 4 commits intomasterfrom
failing-firebase
Jun 12, 2019
Merged

Add failing Firebase test#419
Timer merged 4 commits intomasterfrom
failing-firebase

Conversation

@Timer
Copy link
Member

@Timer Timer commented Jun 11, 2019

Related #392

Node:

joes-mbp:ncc joe$ node test/integration/firebase.2.js 
[2019-06-11T17:46:04.571Z]  @firebase/firestore: Firestore (6.1.1): Could not reach Cloud Firestore backend. Connection failed 1 times. Most recent error: FirebaseError: [code=not-found]: 5 NOT_FOUND: The project noop does not exist or it does not contain an active Cloud Datastore or Cloud Firestore database. Please visit http://console.cloud.google.com to create a project or https://console.cloud.google.com/datastore/setup?project=noop to add a Cloud Datastore or Cloud Firestore database. Note that Cloud Datastore or Cloud Firestore always have an associated App Engine app and this app must not be disabled.
This typically indicates that your device does not have a healthy Internet connection at the moment. The client will operate in offline mode until it is able to successfully connect to the backend.

ncc:

joes-mbp:ncc joe$ node dist/ncc/cli.js run test/integration/firebase.2.js --no-cache
ncc: Version 0.19.0-beta.1
ncc: Compiling file /Users/joe/Desktop/scratch/ncc/test/integration/firebase.2.js
   0kB  assets/protobuf/source_context.proto
   0kB  assets/protobuf/source_context.json
   1kB  assets/protos/google/api/annotations.proto
   1kB  assets/protobuf/api.proto
   1kB  assets/api.proto
   2kB  assets/protobuf/type.proto
   2kB  assets/protos/update.sh
   2kB  assets/protos/google/protobuf/empty.proto
   3kB  assets/protobuf/api.json
   3kB  assets/protos/google/firestore/v1/common.proto
   3kB  assets/protos/google/type/latlng.proto
   4kB  assets/protos/google/protobuf/wrappers.proto
   4kB  assets/protos/google/protobuf/struct.proto
   4kB  assets/protos/google/rpc/status.proto
   5kB  assets/protos/google/firestore/v1/document.proto
   5kB  assets/protobuf/type.json
   6kB  assets/protos/google/protobuf/timestamp.proto
   6kB  assets/protos/google/protobuf/any.proto
   7kB  assets/protobuf/descriptor.proto
   7kB  assets/protos/google/firestore/v1/query.proto
  10kB  assets/protos/google/firestore/v1/write.proto
  15kB  assets/protos/google/api/http.proto
  20kB  assets/protobuf/descriptor.json
  26kB  assets/protos/google/firestore/v1/firestore.proto
  26kB  assets/firestore.proto
  34kB  assets/protos/firestore_proto_api.d.ts
  36kB  assets/protos/google/protobuf/descriptor.proto
 121kB  sourcemap-register.js
 272kB  assets/roots.pem
1531kB  assets/extension_binary/node-v64-darwin-x64-unknown/grpc_node.node
1531kB  assets/src/node/extension_binary/node-v64-darwin-x64-unknown/grpc_node.node
1658kB  index.js.map
2344kB  index.js
7690kB  [3951ms] - ncc 0.19.0-beta.1
[2019-06-11T17:46:16.330Z]  @firebase/firestore: Firestore (6.1.1): INTERNAL UNHANDLED ERROR:  Error: unresolvable extensions: 'extend google.protobuf.MethodOptions' in .google.api
    at Root.resolveAll (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/node_modules/protobufjs/src/root.js:243:1)
    at Object.loadSync (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:43415:16)
    at loadProtos (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:16778:41)
    at NodePlatform.module.exports.278.NodePlatform.loadConnection (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:16815:22)
    at FirestoreClient.module.exports.278.FirestoreClient.initializeRest (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:28414:14)
    at /private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:28239:64
(node:48327) UnhandledPromiseRejectionWarning: Error: unresolvable extensions: 'extend google.protobuf.MethodOptions' in .google.api
    at Root.resolveAll (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/node_modules/protobufjs/src/root.js:243:1)
    at Object.loadSync (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:43415:16)
    at loadProtos (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:16778:41)
    at NodePlatform.module.exports.278.NodePlatform.loadConnection (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:16815:22)
    at FirestoreClient.module.exports.278.FirestoreClient.initializeRest (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:28414:14)
    at /private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:28239:64
(node:48327) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:48327) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/node_modules/protobufjs/src/root.js:243
        throw Error("unresolvable extensions: " + this.deferred.map(function(field) {
^
Error: unresolvable extensions: 'extend google.protobuf.MethodOptions' in .google.api
    at Root.resolveAll (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/node_modules/protobufjs/src/root.js:243:1)
    at Object.loadSync (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:43415:16)
    at loadProtos (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:16778:41)
    at NodePlatform.module.exports.278.NodePlatform.loadConnection (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:16815:22)
    at FirestoreClient.module.exports.278.FirestoreClient.initializeRest (/private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:28414:14)
    at /private/var/folders/c3/vytj6_h56b77f_g72smntm3m0000gn/T/a707d6b7ee4afe5b484993180e617e2d/index.js:28239:64
joes-mbp:ncc joe$ 

@Timer Timer requested review from guybedford and styfle as code owners June 11, 2019 17:45
@guybedford
Copy link
Contributor

Excellent work tracking this down! Will dig into it further now.

styfle
styfle previously approved these changes Jun 11, 2019
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@guybedford
Copy link
Contributor

I finally managed to put a fix together for this in vercel/webpack-asset-relocator-loader#49.

@guybedford guybedford changed the base branch from master to loader-update June 12, 2019 17:25
@Timer Timer closed this Jun 12, 2019
@Timer Timer reopened this Jun 12, 2019
@guybedford guybedford changed the base branch from loader-update to master June 12, 2019 17:38
@codecov-io
Copy link

codecov-io commented Jun 12, 2019

Codecov Report

Merging #419 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files          13       13           
  Lines         391      391           
=======================================
  Hits          288      288           
  Misses        103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a85da7...c5f50f9. Read the comment docs.

@Timer Timer merged commit 760ec2b into master Jun 12, 2019
@styfle styfle deleted the failing-firebase branch June 12, 2019 18:42
@guybedford guybedford mentioned this pull request Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants