Merged
Conversation
styfle
approved these changes
Mar 19, 2021
Contributor
Author
|
It turns out I spoke too soon here and @sokra has done some amazing work smoothing these edge cases (also per https://sokra.github.io/interop-test/). As long as we are in the strict interop mode for Webpack there is full Node.js compat on the API patterns now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a failing test case for one of the few of the remaining module interop cases that is different between Webpack and Node.js.
I'm hopeful we can get an upstream fix for this in Webpack in some form.