Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add stringify-loader #742

Merged
merged 2 commits into from Aug 11, 2021
Merged

fix: add stringify-loader #742

merged 2 commits into from Aug 11, 2021

Conversation

@jpcloureiro
Copy link
Contributor

@jpcloureiro jpcloureiro commented Aug 3, 2021

stringify-loader is needed for watched builds since release v0.28.6

fixes #716

@jpcloureiro jpcloureiro requested review from styfle and Timer as code owners Aug 3, 2021
@jpcloureiro jpcloureiro changed the title fix: add strigify-loader fix: add stringify-loader Aug 3, 2021
stringify-loader is needed for watched builds
since release v0.28.6
@guybedford
Copy link
Collaborator

@guybedford guybedford commented Aug 11, 2021

Thanks for the PR. I wonder why the watcher tests were unable to catch this one? Is there anyway to include the specific test case or at least a replication to manually verify what this fixes?

Loading

styfle
styfle approved these changes Aug 11, 2021
Copy link
Member

@styfle styfle left a comment

Great work, thanks! 🎉

Loading

@styfle styfle merged commit 8380a06 into vercel:main Aug 11, 2021
5 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants