test(app-basepath): increase waitForElementByCss timeout for hard-nav test - #91920
Merged
Conversation
… test In dev mode, navigating from a Pages Router page to an App Router page triggers on-demand compilation, which can exceed the default 10s timeout before #page-2 appears. Raise the timeout to 30s to avoid the flake. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Failing test suitesCommit: 61223a5 | About building and testing Next.js
Expand output● page features telemetry › production mode › should detect app page counts ● page features telemetry › production mode › detects reportWebVitals with no _app correctly for
Expand output● next/dynamic › production mode › should load a Pages Router page correctly ● next/dynamic › production mode › should load a App Router page correctly
Expand output● after() in static pages › runs after during build
Expand output● app dir client cache with parallel routes › prefetch={true} › should re-use the cache for the full page, only for 5 mins
Expand output● segment cache (basic tests) › navigate with prefetched data
Expand output● Graceful Shutdown › production (next start) › should not accept new requests during shutdown cleanup › should stop accepting new requests when shutting down ● Graceful Shutdown › production (standalone mode) › should not accept new requests during shutdown cleanup › should stop accepting new requests when shutting down |
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
sokra
marked this pull request as ready for review
March 26, 2026 18:25
eps1lon
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Increase the
waitForElementByCss('#page-2', ...)timeout in theapp dir - basepath › should successfully hard navigate from pages -> apptest from the default 10 s to 30 s.Why?
Datadog test runs
The test navigates from a Pages Router page (
/base/pages-path) to an App Router page (/base/another) via a hard (non-client-side) navigation. In dev mode, the destination App Router page is compiled on demand the first time it is visited. That compilation can take longer than the default 10 swaitForElementByCsstimeout, causing the test to fail spuriously with:How?
Pass
30000(30 s) as the second argument towaitForElementByCss. This matches the pattern used elsewhere in the test suite for dev-mode tests that are subject to on-demand compilation latency. No runtime code changes are needed — this is purely a test-side fix.