feat(cli): use default template when GH is offline #12194

marcosvega91 · 2020-04-25T13:38:32Z

I add a prompt if there is an error when trying to download example files.
Maybe could be better to add an error class and in create-app.ts on every "console.error" trow a new Exception and manage it in catch. What you think ? 👯

ijjk · 2020-04-25T13:44:55Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	11.6s	11.3s	-257ms
nodeModulesSize	55.2 MB	55.2 MB	✓

Page Load Tests Overall increase ✓

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.928	1.877	-0.05
/ avg req/sec	1296.69	1331.95	⚠️ +35.26
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.965	0.937	-0.03
/error-in-render avg req/sec	2590.37	2667.35	⚠️ +76.98

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..45d6.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.87 kB	6.87 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
index.html gzip	929 B	929 B	✓
link.html gzip	939 B	939 B	✓
withRouter.html gzip	926 B	926 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	11.9s	11.9s	⚠️ +48ms
nodeModulesSize	55.2 MB	55.2 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..45d6.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.87 kB	6.87 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	595 kB	595 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-25T21:01:53Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	13s	13.2s	⚠️ +238ms
nodeModulesSize	55.3 MB	55.3 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.317	2.334	⚠️ +0.02
/ avg req/sec	1079.03	1071.06	-7.97
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.31	1.366	⚠️ +0.06
/error-in-render avg req/sec	1908.63	1830.45	-78.18

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..45d6.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.87 kB	6.87 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
index.html gzip	929 B	929 B	✓
link.html gzip	939 B	939 B	✓
withRouter.html gzip	926 B	926 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	14s	13.9s	-79ms
nodeModulesSize	55.3 MB	55.3 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..45d6.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.87 kB	6.87 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	595 kB	595 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

timneutkens

Ideally we'd automatically retry, then if the retry fails (eg 3 retries fail) we show a message "Could not download example x because of error y, do you want to use the default template instead" That way the user is never blocked when eg github is down.

If there is an error downloading example files, the programm will try 3 times. After that the user can choose to use the default templace instead of the example one.

…a91/next.js into feature/retry_on_error

marcosvega91 · 2020-04-26T17:42:03Z

Ideally we'd automatically retry, then if the retry fails (eg 3 retries fail) we show a message "Could not download example x because of error y, do you want to use the default template instead" That way the user is never blocked when eg github is down.

I have added this behavior. In this case the function will retry three times only on error during downloading of example

ijjk · 2020-04-26T17:46:12Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	12.1s	11.9s	-180ms
nodeModulesSize	55.3 MB	55.3 MB	✓

Page Load Tests Overall increase ✓

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.104	2.039	-0.06
/ avg req/sec	1188.19	1226.16	⚠️ +37.97
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.212	1.208	0
/error-in-render avg req/sec	2062.4	2068.98	⚠️ +6.58

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.27 kB	6.27 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ac5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	4.82 kB	4.82 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
index.html gzip	927 B	927 B	✓
link.html gzip	937 B	937 B	✓
withRouter.html gzip	925 B	925 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	12.6s	12.5s	-99ms
nodeModulesSize	55.3 MB	55.3 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.27 kB	6.27 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ac5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	4.82 kB	4.82 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	595 kB	595 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-26T17:49:26Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	12.3s	12.3s	⚠️ +64ms
nodeModulesSize	55.3 MB	55.3 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.128	2.201	⚠️ +0.07
/ avg req/sec	1174.96	1135.75	-39.21
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.213	1.233	⚠️ +0.02
/error-in-render avg req/sec	2061.11	2027.27	-33.84

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.27 kB	6.27 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ac5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	4.82 kB	4.82 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
index.html gzip	927 B	927 B	✓
link.html gzip	937 B	937 B	✓
withRouter.html gzip	925 B	925 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	13.4s	13.5s	⚠️ +89ms
nodeModulesSize	55.3 MB	55.3 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.27 kB	6.27 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..ac5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.8 kB	56.8 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	4.82 kB	4.82 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.88 kB	6.88 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	595 kB	595 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

…error

ijjk · 2020-05-25T17:42:27Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	12.5s	12.7s	⚠️ +270ms
nodeModulesSize	66.4 MB	66.4 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.131	2.097	-0.03
/ avg req/sec	1173.24	1192.19	⚠️ +18.95
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.288	1.322	⚠️ +0.03
/error-in-render avg req/sec	1941.45	1891.32	-50.13

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..1e23.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
index.html gzip	927 B	927 B	✓
link.html gzip	937 B	937 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	13.4s	13.1s	-288ms
nodeModulesSize	66.4 MB	66.4 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..1e23.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_error.js	844 kB	844 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	844 kB	844 kB	✓
link.js	882 kB	882 kB	✓
routerDirect.js	874 kB	874 kB	✓
withRouter.js	874 kB	874 kB	✓
Overall change	4.33 MB	4.33 MB	✓

fixed

ijjk · 2020-05-26T16:30:44Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	12s	11.8s	-133ms
nodeModulesSize	66.4 MB	66.4 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.023	2.046	⚠️ +0.02
/ avg req/sec	1235.93	1222.07	-13.86
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.15	1.191	⚠️ +0.04
/error-in-render avg req/sec	2174.39	2099.64	-74.75

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..1e23.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
index.html gzip	927 B	927 B	✓
link.html gzip	937 B	937 B	✓
withRouter.html gzip	924 B	924 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
buildDuration	12.9s	12.9s	-22ms
nodeModulesSize	66.4 MB	66.4 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..1e23.js gzip	10.5 kB	10.5 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57 kB	57 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
main-HASH.module.js gzip	5.67 kB	5.67 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.92 kB	6.92 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.5 kB	52.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.js gzip	1.26 kB	1.26 kB	✓
_error.js gzip	3.25 kB	3.25 kB	✓
hooks.js gzip	881 B	881 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	8.22 kB	8.22 kB	✓

Client Pages Modern

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_app.module.js gzip	604 B	604 B	✓
_error.module.js gzip	2.04 kB	2.04 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.33 kB	5.33 kB	✓

Client Build Manifests

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	marcosvega91/next.js feature/retry_on_error	Change
_error.js	844 kB	844 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	844 kB	844 kB	✓
link.js	882 kB	882 kB	✓
routerDirect.js	874 kB	874 kB	✓
withRouter.js	874 kB	874 kB	✓
Overall change	4.33 MB	4.33 MB	✓

fix vercel#12136 I add a prompt if there is an error when trying to download example files. Maybe could be better to add an error class and in create-app.ts on every "console.error" trow a new Exception and manage it in catch. What you think ? 👯

[create-next-app] Permit user to retry to download example files

dcf2cf3

marcosvega91 requested review from Timer, ijjk, lfades and timneutkens as code owners April 25, 2020 13:38

Merge branch 'canary' into feature/retry_on_error

ece7156

timneutkens previously requested changes Apr 26, 2020

View reviewed changes

marcosvega91 added 2 commits April 26, 2020 19:36

Add auto retry for creating app

3591ac1

If there is an error downloading example files, the programm will try 3 times. After that the user can choose to use the default templace instead of the example one.

Merge branch 'feature/retry_on_error' of https://github.com/marcosveg…

b10a417

…a91/next.js into feature/retry_on_error

Merge branch 'canary' into feature/retry_on_error

5350ab5

timneutkens assigned Timer and lfades May 24, 2020

Merge remote-tracking branch 'upstream/canary' into feature/retry_on_…

376b72c

…error

Timer unassigned lfades May 25, 2020

Timer added 2 commits May 26, 2020 11:53

Merge branch 'canary' into feature/retry_on_error

005744b

Use library

aacdfd1

Timer approved these changes May 26, 2020

View reviewed changes

Timer added this to the 9.4.3 milestone May 26, 2020

Timer added the Type: Enhancement label May 26, 2020

Timer changed the title ~~[create-next-app] Permit user to retry to download example files~~ feat(cli): use default template when GH is offline May 26, 2020

kodiakhq bot merged commit b3e45fa into vercel:canary May 26, 2020

marcosvega91 deleted the feature/retry_on_error branch May 26, 2020 16:51

styfle mentioned this pull request Sep 15, 2021

upgrade to typescript 4.4.3 #29112

Merged

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(cli): use default template when GH is offline #12194

feat(cli): use default template when GH is offline #12194

Uh oh!

marcosvega91 commented Apr 25, 2020

Uh oh!

ijjk commented Apr 25, 2020

Uh oh!

ijjk commented Apr 25, 2020

Uh oh!

timneutkens left a comment

Uh oh!

marcosvega91 commented Apr 26, 2020

Uh oh!

ijjk commented Apr 26, 2020

Uh oh!

ijjk commented Apr 26, 2020

Uh oh!

ijjk commented May 25, 2020

Uh oh!

ijjk commented May 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(cli): use default template when GH is offline #12194

feat(cli): use default template when GH is offline #12194

Uh oh!

Conversation

marcosvega91 commented Apr 25, 2020

Uh oh!

ijjk commented Apr 25, 2020

Stats from current PR

Uh oh!

ijjk commented Apr 25, 2020

Stats from current PR

Uh oh!

timneutkens left a comment

Choose a reason for hiding this comment

Uh oh!

marcosvega91 commented Apr 26, 2020

Uh oh!

ijjk commented Apr 26, 2020

Stats from current PR

Uh oh!

ijjk commented Apr 26, 2020

Stats from current PR

Uh oh!

ijjk commented May 25, 2020

Stats from current PR

Uh oh!

ijjk commented May 26, 2020

Stats from current PR

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants