Skip to content

Remove buildId test as it's no longer relevant #56316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Oct 2, 2023
Merged

Remove buildId test as it's no longer relevant #56316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions test/integration/config-mjs/next.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,4 @@ export default {
env: {
customVar: 'hello',
},
webpack(config, { buildId, webpack }) {
config.plugins.push(
new webpack.DefinePlugin({
'process.env.CONFIG_BUILD_ID': JSON.stringify(buildId),
})
)

return config
},
}
3 changes: 0 additions & 3 deletions test/integration/config-mjs/pages/build-id.js
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions test/integration/config-mjs/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ describe('Configuration', () => {
// pre-build all pages at the start
await Promise.all([
renderViaHTTP(context.appPort, '/next-config'),
renderViaHTTP(context.appPort, '/build-id'),
renderViaHTTP(context.appPort, '/module-only-component'),
])
})
Expand Down Expand Up @@ -58,11 +57,6 @@ describe('Configuration', () => {
expect($('#server-and-client').text()).toBe('/static')
})

test('renders the build id in development mode', async () => {
const $ = await get$('/build-id')
expect($('#buildId').text()).toBe('development')
})

test('correctly imports a package that defines `module` but no `main` in package.json', async () => {
const $ = await get$('/module-only-content')
expect($('#messageInAPackage').text()).toBe('OK')
Expand Down
9 changes: 0 additions & 9 deletions test/integration/config/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,4 @@ module.exports = {
env: {
customVar: 'hello',
},
webpack(config, { buildId, webpack }) {
config.plugins.push(
new webpack.DefinePlugin({
'process.env.CONFIG_BUILD_ID': JSON.stringify(buildId),
})
)

return config
},
}
6 changes: 0 additions & 6 deletions test/integration/config/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ describe('Configuration', () => {
// pre-build all pages at the start
await Promise.all([
renderViaHTTP(context.appPort, '/next-config'),
renderViaHTTP(context.appPort, '/build-id'),
renderViaHTTP(context.appPort, '/module-only-component'),
])
})
Expand Down Expand Up @@ -58,11 +57,6 @@ describe('Configuration', () => {
expect($('#server-and-client').text()).toBe('/static')
})

test('renders the build id in development mode', async () => {
const $ = await get$('/build-id')
expect($('#buildId').text()).toBe('development')
})

test('correctly imports a package that defines `module` but no `main` in package.json', async () => {
const $ = await get$('/module-only-content')
expect($('#messageInAPackage').text()).toBe('OK')
Expand Down