Document default values in cookies options#72183
Merged
ijjk merged 3 commits intovercel:canaryfrom Nov 1, 2024
karlhorky:patch-2
Merged
Document default values in cookies options#72183ijjk merged 3 commits intovercel:canaryfrom karlhorky:patch-2
ijjk merged 3 commits intovercel:canaryfrom
karlhorky:patch-2
Conversation
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
ijjk
approved these changes
Nov 1, 2024
Contributor
Author
|
@ijjk thanks for the review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Document the default values for
cookies, eg. used incookies().set(), fix typoWhy?
Default values are undocumented (probably because there are almost no default values)
How?
path, based on thepackages/next/src/compiled/@edge-runtime/cookies/index.jscode:next.js/packages/next/src/compiled/@edge-runtime/cookies/index.js
Lines 317 to 328 in 98fa024
,typo