-
Notifications
You must be signed in to change notification settings - Fork 30.1k
refactor(turbopack): Update callsites for OperationVc #72776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
only expose VcOperation into JS to connect to the whole compution (and be strongly consistent with the whole compuation).
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Failing test suitesCommit: a998145
Expand output● Conflict between app file and pages file › should show error overlay for /another ● Conflict between app file and pages file › should show error overlay for / ● Conflict between app file and pages file › should support hmr with conflicts ● Conflict between app file and pages file › should not show error overlay for non conflict pages under app or pages dir ● Conflict between app file and pages file › should error again when there is new conflict Read more about building and testing Next.js in contributing.md.
Expand output● app dir - navigation › navigating to dynamic params & changing the casing › should load the page correctly Read more about building and testing Next.js in contributing.md. |
a7973b1 to
93893d6
Compare
93893d6 to
9166c5a
Compare
494ba77 to
8e51f56
Compare
|
The |
`VcArc` represents values passed through napi to next.js and back. Because these values exit the scope of turbo-tasks, similar to how `State` works, they must be operations, so that they're recomputed/"kept alive" when read. These changes were extracted from @sokra's original `OperationVc` work (mostly preserved here: #72776), though adapted significantly for the removal of the `OperationVc::new()` constructor.

This is split out from the PR that introduces the
OperationVctype (#70242) to allow for easier review.Closes PACK-3683