Fix race condition in session middleware (#51628) #77415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes vercel#51628 ## Summary This PR fixes a race condition in the session middleware of the with-passport-and-next-connect example. The issue was caused by overriding es.end with an async function, which led to API requests resolving before the session cookie was set. ## Changes - Removed async override of es.end - Implemented es.on('finish', callback) to ensure session persistence - Prevents stalled API requests and improves session consistency ## Testing - Run the example and check /api/auth/session response - Confirm session cookie is set correctly - Ensure no stalled requests occur Let me know if any further changes are needed! 🚀
ijjk
added
Documentation
Contributor
|
@ijjk i think we should close this pr as it is clearly a spam, sorry you have to deal with kind of behaviour |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51628
Summary
This PR fixes a race condition in the session middleware of the with-passport-and-next-connect example. The issue was caused by overriding
es.end with an async function, which led to API requests resolving before the session cookie was set.
Changes
es.end
es.on('finish', callback) to ensure session persistence
Testing
Let me know if any further changes are needed! 🚀