Skip to content

[dev-overlay] Re-enable some Turbopack HMR Redbox tests #77529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eps1lon wants to merge 2 commits into
base: canary
Choose a base branch
from
Draft

[dev-overlay] Re-enable some Turbopack HMR Redbox tests #77529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3433ac1
[dev-overlay] Log errors when sourcemapping fails in Next.js internal…
eps1lon Mar 26, 2025
a69cc31
[dev-overlay] Re-enable some Turbopack HMR Redbox tests
eps1lon Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/next/src/client/components/react-dev-overlay/server/middleware-turbopack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,16 @@ export function getOverlayMiddleware(project: Project, projectPath: string) {
}
return { status: 'fulfilled', value: stackFrame }
} catch (error) {
if (process.env.__NEXT_TEST_MODE) {
console.error(
new Error(
`Failed to create original stack frame for \n${JSON.stringify(frame, null, 2)}`,
{
cause: error,
}
)
)
}
return {
status: 'rejected',
reason: inspect(error, { colors: false }),
Expand Down
62 changes: 35 additions & 27 deletions test/development/acceptance-app/ReactRefreshLogBox.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ describe('ReactRefreshLogBox app', () => {
})

// Module trace is only available with webpack 5
test('conversion to class component (1)', async () => {
it('conversion to class component (1)', async () => {
await using sandbox = await createSandbox(next)
const { browser, session } = sandbox

Expand Down Expand Up @@ -343,28 +343,22 @@ describe('ReactRefreshLogBox app', () => {
`
)

if (isTurbopack) {
// TODO(veil): Turbopack is flaky. Possibly related to https://linear.app/vercel/issue/NDX-920/turbopack-errors-after-hmr-have-no-stacktraces-in-affected-chunks
// Should use `await expect(browser).toDisplayRedbox()`
await session.assertHasRedbox()
} else {
await expect(browser).toDisplayRedbox(`
{
"count": 1,
"description": "Error: ",
"environmentLabel": null,
"label": "Runtime Error",
"source": "Child.js (4:11) @ ClickCount.render
> 4 | throw new Error()
| ^",
"stack": [
"ClickCount.render Child.js (4:11)",
"Home index.js (6:7)",
"Page app/page.js (4:10)",
],
}
`)
}
await expect(browser).toDisplayRedbox(`
{
"count": 1,
"description": "Error: ",
"environmentLabel": null,
"label": "Runtime Error",
"source": "Child.js (4:11) @ ClickCount.render
> 4 | throw new Error()
| ^",
"stack": [
"ClickCount.render Child.js (4:11)",
"Home index.js (6:7)",
"Page app/page.js (4:10)",
],
}
`)

await session.patch(
'Child.js',
Expand Down Expand Up @@ -1445,16 +1439,30 @@ describe('ReactRefreshLogBox app', () => {

// TODO: The error overlay is not closed when restoring the working code.
for (const type of ['server' /* , 'client' */]) {
test(`${type} component can recover from error thrown in the module`, async () => {
it(`${type} component can recover from error thrown in the module`, async () => {
await using sandbox = await createSandbox(next, undefined, '/' + type)
const { browser, session } = sandbox

await next.patchFile('index.js', "throw new Error('module error')")

if (isTurbopack) {
// TODO(veil): Turbopack is flaky. Possibly related to https://linear.app/vercel/issue/NDX-920/turbopack-errors-after-hmr-have-no-stacktraces-in-affected-chunks
// Should use `await expect(browser).toDisplayRedbox()`
await session.assertHasRedbox()
await expect({ browser, next }).toDisplayRedbox(`
{
"count": 1,
"description": "Error: module error",
"environmentLabel": null,
"label": "Runtime Error",
"source": "index.js (1:7) @ [project]/index.js [app-rsc] (ecmascript)
> 1 | throw new Error('module error')
| ^",
"stack": [
"[project]/index.js [app-rsc] (ecmascript) index.js (1:7)",
"[project]/app/server/page.js [app-rsc] (ecmascript) app/server/page.js (1:1)",
"[project]/app/server/page.js [app-rsc] (ecmascript, Next.js server component) app/server/page.js (4:1)",
"<FIXME-next-dist-dir>",
],
}
`)
} else {
await expect({ browser, next }).toDisplayRedbox(`
{
Expand Down
Loading