Turbopack: convert EcmascriptExports to a struct to be able to add more fields

[sokra]

No description provided.

[sokra]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Turbopack: add resolve_export property to ChunkingType #84059
• Turbopack: use more restricted enum of esm import #84058
• Turbopack: organize tree shaking code #84057
• Turbopack: use exports.evaluation to check for side effects, remove is_marked_as_side_effect_free trait method #84056
• Turbopack: add evaluation info to EsmExports #84055
• Turbopack: convert EcmascriptExports to a struct to be able to add more fields #84054 👈 (View in Graphite)
• Turbopack: side effects optimization cleanups #82467
• Turbopack: refactor side effects optimization #82466
• Turbopack: add more side effects test cases #82465
• Turbopack: split basic side effects optimization test #82464
• Turbopack: enable side effects optimization by default in all test cases #82463
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

[vercel]

Additional Comments:

turbopack/crates/turbopack-ecmascript/src/inlined_bytes_module.rs (line 75):

The file uses the old EcmascriptExports::Value.cell() syntax which no longer exists after the refactoring, causing a compilation error.

View Details

📝 Patch Details

diff --git a/turbopack/crates/turbopack-ecmascript/src/inlined_bytes_module.rs b/turbopack/crates/turbopack-ecmascript/src/inlined_bytes_module.rs
index 18b1c9b9c3..a565ad0322 100644
--- a/turbopack/crates/turbopack-ecmascript/src/inlined_bytes_module.rs
+++ b/turbopack/crates/turbopack-ecmascript/src/inlined_bytes_module.rs
@@ -16,7 +16,7 @@ use turbopack_core::{
 use crate::{
     chunk::{
         EcmascriptChunkItem, EcmascriptChunkItemContent, EcmascriptChunkPlaceable,
-        EcmascriptChunkType, EcmascriptExports,
+        EcmascriptChunkType, EcmascriptExports, EcmascriptExportsType,
     },
     runtime_functions::TURBOPACK_EXPORT_VALUE,
     utils::StringifyJs,
@@ -72,7 +72,10 @@ impl ChunkableModule for InlinedBytesJsModule {
 impl EcmascriptChunkPlaceable for InlinedBytesJsModule {
     #[turbo_tasks::function]
     fn get_exports(&self) -> Vc<EcmascriptExports> {
-        EcmascriptExports::Value.cell()
+        EcmascriptExports {
+            ty: EcmascriptExportsType::Value,
+        }
+        .cell()
     }
 
     #[turbo_tasks::function]

Analysis

Compilation error: EcmascriptExports::Value syntax no longer valid

What fails: InlinedBytesJsModule.get_exports() uses outdated enum syntax EcmascriptExports::Value.cell() but EcmascriptExports was refactored from enum to struct

How to reproduce:

cd turbopack && cargo check --package turbopack-ecmascript

Result: Compilation error no associated item named 'Value' found for struct 'EcmascriptExports' in turbopack/crates/turbopack-ecmascript/src/inlined_bytes_module.rs:75

Expected: Should compile successfully using struct syntax EcmascriptExports { ty: EcmascriptExportsType::Value }.cell() matching other files in codebase