fix(third-parties): remove global Window augmentation to avoid type degradation#85556
Open
cosocaf wants to merge 1 commit into
Open
fix(third-parties): remove global Window augmentation to avoid type degradation#85556cosocaf wants to merge 1 commit into
Window augmentation to avoid type degradation#85556cosocaf wants to merge 1 commit into
Conversation
… degradation
Removes the global `Window` augmentation in `@next/third-parties` that introduced a string index signature (`[key: string]: any]`),
which caused mapped types involving `Window` to collapse into `{ [k: string]: any }`.
The change uses a local cast instead, preserving runtime behavior while maintaining type safety across the ecosystem.
- Deleted `packages/third-parties/src/types/google.ts` global `Window` declaration.
- Updated `google/ga.tsx` and `google/gtm.tsx` to locally cast window as `{ [key: string]: Object[] }` before accessing dynamic data layer keys.
No runtime behavior changes.
- The `dataLayer` key name is dynamic; declaring it globally adds no type safety.
- The global index signature caused far-reaching type degradation in apps, DOM utilities, and libraries.
- Removing it restores consistency with `lib.dom.d.ts` and avoids polluting global scope.
- Jest-based type tests are out of scope; this fix only targets type definitions.
- While this issue surfaced clearly with `@types/jsdom`, it applies equally to any consumer using `Omit<Window, ...>` or similar type operations.
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85555
Summary
Removes the global
Windowaugmentation in@next/third-partiesthat introduced a string index signature ([key: string]: any]),which caused mapped types involving
Windowto collapse into{ [k: string]: any }.The change uses a local cast instead, preserving runtime behavior while maintaining type safety across the ecosystem.
Details
packages/third-parties/src/types/google.tsglobalWindowdeclaration.google/ga.tsxandgoogle/gtm.tsxto locally cast window as{ [key: string]: Object[] }before accessing dynamic data layer keys.No runtime behavior changes.
Rationale
dataLayerkey name is dynamic; declaring it globally adds no type safety.lib.dom.d.tsand avoids polluting global scope.Notes
@types/jsdom, it applies equally to any consumer usingOmit<Window, ...>or similar type operations.