Fix/prefetch always 200#85643
Closed
denesbeck wants to merge 5 commits into
Closed
Conversation
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #85121
Starting from Next.js v15.4.1 (commit
256cd5b571), prefetch requests for SSG/ISR pages always returned200 OKstatus codes instead of304 Not Modified, even when the content hadn't changed. This forced full payload downloads on every prefetch (e.g., on hover or in-viewport), unnecessarily increasing CDN traffic and bandwidth costs.Root Cause:
In commit
256cd5b571("Add response handling inside handlers"), the Pages Router handler was modified to create RenderResult instances withBuffer.from()for cached content:The problem:
RenderResult.isDynamicreturnstruewhen the response is a Buffer (not a string):Test repository for testing changes (to prevent version conflicts): https://github.com/denesbeck/next-test-304
Simply package the Next.js version from this branch into the repository. Then, run
npm run buildandnpm run start.