Turbopack: mark more modules as side effect free #86136
Merged
+54
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mischnic
approved these changes
Nov 14, 2025
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
turbopack/crates/turbopack-ecmascript/src/inlined_bytes_module.rs
Outdated
Show resolved
Hide resolved
ijjk
added
created-by: Turbopack team
sokra
changed the base branch from
sokra/all-module-types-side-effects-false
to
graphite-base/86136
sokra
force-pushed
the
graphite-base/86136
branch
from
7f2927d to
8c8030e
Compare
sokra
force-pushed
the
sokra/more-side-effect-free
branch
from
7322d29 to
357a1f7
Compare
sokra
force-pushed
the
sokra/more-side-effect-free
branch
from
357a1f7 to
6d1a86e
Compare
sokra
force-pushed
the
sokra/more-side-effect-free
branch
from
6d1a86e to
16bf5ec
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
These modules can be always side effect free.