Skip to content

Turbopack: mark more modules as side effect free #86136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
Merged

Turbopack: mark more modules as side effect free #86136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48108a4
Turbopack: mark more modules as side effect free
sokra Nov 14, 2025
16bf5ec
fixup
sokra Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use anyhow::Result;
use turbo_rcstr::rcstr;
use turbo_tasks::{ResolvedVc, Vc};
use turbo_tasks_fs::glob::Glob;
use turbopack_core::{
asset::{Asset, AssetContent},
chunk::{ChunkableModule, ChunkingContext, availability_info::AvailabilityInfo},
Expand Down Expand Up @@ -60,6 +61,14 @@ impl Module for AsyncLoaderModule {
.await?,
)]))
}

#[turbo_tasks::function]
fn is_marked_as_side_effect_free(
self: Vc<Self>,
_side_effect_free_packages: Vc<Glob>,
) -> Vc<bool> {
Vc::cell(true)
}
}

#[turbo_tasks::value_impl]
Expand Down
9 changes: 9 additions & 0 deletions turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use anyhow::Result;
use turbo_rcstr::{RcStr, rcstr};
use turbo_tasks::{ResolvedVc, TryJoinIterExt, Vc};
use turbo_tasks_fs::glob::Glob;
use turbopack_core::{
asset::{Asset, AssetContent},
chunk::{
Expand Down Expand Up @@ -146,6 +147,14 @@ impl Module for ManifestAsyncModule {
.await?,
))
}

#[turbo_tasks::function]
fn is_marked_as_side_effect_free(
self: Vc<Self>,
_side_effect_free_packages: Vc<Glob>,
) -> Vc<bool> {
Vc::cell(true)
}
}

#[turbo_tasks::value_impl]
Expand Down
10 changes: 9 additions & 1 deletion turbopack/crates/turbopack-ecmascript/src/references/require_context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use turbo_tasks::{
FxIndexMap, NonLocalValue, ResolvedVc, ValueToString, Vc, debug::ValueDebugFormat,
trace::TraceRawVcs,
};
use turbo_tasks_fs::{DirectoryContent, DirectoryEntry, FileSystemPath};
use turbo_tasks_fs::{DirectoryContent, DirectoryEntry, FileSystemPath, glob::Glob};
use turbopack_core::{
asset::{Asset, AssetContent},
chunk::{
Expand Down Expand Up @@ -421,6 +421,14 @@ impl Module for RequireContextAsset {
.collect(),
))
}

#[turbo_tasks::function]
fn is_marked_as_side_effect_free(
self: Vc<Self>,
_side_effect_free_packages: Vc<Glob>,
) -> Vc<bool> {
Vc::cell(true)
}
}

#[turbo_tasks::value_impl]
Expand Down
9 changes: 9 additions & 0 deletions turbopack/crates/turbopack-ecmascript/src/worker_chunk/module.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use anyhow::Result;
use turbo_rcstr::{RcStr, rcstr};
use turbo_tasks::{ResolvedVc, ValueToString, Vc};
use turbo_tasks_fs::glob::Glob;
use turbopack_core::{
asset::{Asset, AssetContent},
chunk::{
Expand Down Expand Up @@ -51,6 +52,14 @@ impl Module for WorkerLoaderModule {
.await?,
)]))
}

#[turbo_tasks::function]
fn is_marked_as_side_effect_free(
self: Vc<Self>,
_side_effect_free_packages: Vc<Glob>,
) -> Vc<bool> {
Vc::cell(true)
}
}

#[turbo_tasks::value_impl]
Expand Down
9 changes: 9 additions & 0 deletions turbopack/crates/turbopack-static/src/css.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use turbo_rcstr::{RcStr, rcstr};
use turbo_tasks::{ResolvedVc, Vc};
use turbo_tasks_fs::glob::Glob;
use turbopack_core::{
asset::{Asset, AssetContent},
chunk::ChunkingContext,
Expand Down Expand Up @@ -45,6 +46,14 @@ impl Module for StaticUrlCssModule {
}
ident
}

#[turbo_tasks::function]
fn is_marked_as_side_effect_free(
self: Vc<Self>,
_side_effect_free_packages: Vc<Glob>,
) -> Vc<bool> {
Vc::cell(true)
}
}

#[turbo_tasks::value_impl]
Expand Down
9 changes: 9 additions & 0 deletions turbopack/crates/turbopack-static/src/ecma.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use anyhow::Result;
use turbo_rcstr::{RcStr, rcstr};
use turbo_tasks::{ResolvedVc, Vc};
use turbo_tasks_fs::glob::Glob;
use turbopack_core::{
asset::{Asset, AssetContent},
chunk::{ChunkItem, ChunkType, ChunkableModule, ChunkingContext},
Expand Down Expand Up @@ -57,6 +58,14 @@ impl Module for StaticUrlJsModule {
}
ident
}

#[turbo_tasks::function]
fn is_marked_as_side_effect_free(
self: Vc<Self>,
_side_effect_free_packages: Vc<Glob>,
) -> Vc<bool> {
Vc::cell(true)
}
}

#[turbo_tasks::value_impl]
Expand Down
Loading