-
Notifications
You must be signed in to change notification settings - Fork 30.2k
feat(turbopack): add resolve plugin condition variant of Always and Never #88190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(turbopack): add resolve plugin condition variant of Always and Never #88190
Conversation
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
We could also have a |
bcf2793 to
045b897
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
cdc6e07 to
d20c660
Compare
d20c660 to
19d6864
Compare
0c0ccd6 to
b39ccaa
Compare
Failing test suitesCommit: 1cd421b | About building and testing Next.js
Expand output● segment cache (revalidation) › delay re-prefetch after revalidation to allow CDN propagation |
b39ccaa to
143135a
Compare
143135a to
9c24b9b
Compare
This PR refactors the Resolution Plugin traits to add new
AlwaysorNeverenum variants toresolve condition. This allow plugins (like ExternalsPlugin when no externals are configured) to skip the expensivematches()task calls entirely. Testing on a medium project showed a reduction of ~1.4kresolve_calltasks. I think this can be shared to upstream for future improvement ofresolve pluginSee the metrics for improvements.
