Skip to content

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 29, 2026

Noticed after bumping #89158

@eps1lon eps1lon requested review from bgw and ijjk January 29, 2026 00:23
@eps1lon eps1lon marked this pull request as ready for review January 29, 2026 00:23
Copy link
Member

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Comment on lines 9 to 10
// license might be lower case and not able to be found on case-sensitive
// file systems (ubuntu)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think macOS is the weird one here... 😠

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 29, 2026

Failing test suites

Commit: 632253a | About building and testing Next.js

pnpm test test/integration/telemetry/test/index.test.ts (job)

  • Telemetry CLI > production mode > emits event when swc fails to load (DD)
Expand output

● Telemetry CLI › production mode › emits event when swc fails to load

expect(received).toMatch(expected)

Expected pattern: /NEXT_SWC_LOAD_FAILURE/
Received string:  "⚠ Attempted to load @next/swc-linux-x64-gnu, but an error occurred: Cannot load native addon because loading addons is disabled.
⚠ Attempted to load @next/swc-linux-x64-musl, but an error occurred: Cannot load native addon because loading addons is disabled.
⚠ Attempted to load @next/swc-wasm-nodejs, but it was not installed
⚠ Attempted to load @next/swc-wasm-web, but it was not installed
⨯ Failed to load SWC binary for linux/x64, see more info here: https://nextjs.org/docs/messages/failed-loading-swc·
> Build error occurred
Error: Failed to load SWC binary for linux/x64, see more info here: https://nextjs.org/docs/messages/failed-loading-swc

  at <unknown> (../dist/build/swc/index.js:318:38)
  "
  at Object.toMatch (integration/telemetry/test/index.test.ts:111:24)

pnpm test-start test/e2e/app-dir/segment-cache/prefetch-runtime/prefetch-runtime.test.ts (job)

  • runtime prefetching > in a page > can completely prefetch a page that uses cookies and no uncached IO (DD)
Expand output

● runtime prefetching › in a page › can completely prefetch a page that uses cookies and no uncached IO

apiRequestContext.fetch: socket hang up
Call log:
  - → GET http://localhost:43953/in-page/cookies-only?_rsc=nn07o
  -   user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/130.0.6723.31 Safari/537.36
  -   accept: */*
  -   accept-encoding: gzip,deflate,br
  -   cookie: testCookie=initialValue
  -   next-test-fetch-priority: low
  -   referer: http://localhost:43953/
  -   next-router-prefetch: 1
  -   next-router-segment-prefetch: /_index
  -   next-url: /
  -   rsc: 1
  -   sec-ch-ua: "Chromium";v="130", "HeadlessChrome";v="130", "Not?A_Brand";v="99"
  -   sec-ch-ua-mobile: ?0
  -   sec-ch-ua-platform: "Linux"

  225 |             // server; we pass the request to the server the immediately.
  226 |             result: (async () => {
> 227 |               const originalResponse = await page.request.fetch(request, {
      |                                                           ^
  228 |                 maxRedirects: 0,
  229 |               })
  230 |

  at fetch (lib/router-act.ts:227:59)
  at lib/router-act.ts:245:13
  at routeHandler (lib/router-act.ts:257:7)

● runtime prefetching › in a page › can completely prefetch a page that uses cookies and no uncached IO

apiRequestContext.fetch: socket hang up
Call log:
  - → GET http://localhost:43953/in-page/cookies-only?_rsc=nn07o
  -   user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/130.0.6723.31 Safari/537.36
  -   accept: */*
  -   accept-encoding: gzip,deflate,br
  -   cookie: testCookie=initialValue
  -   next-test-fetch-priority: low
  -   referer: http://localhost:43953/
  -   next-router-prefetch: 1
  -   next-router-segment-prefetch: /_index
  -   next-url: /
  -   rsc: 1
  -   sec-ch-ua: "Chromium";v="130", "HeadlessChrome";v="130", "Not?A_Brand";v="99"
  -   sec-ch-ua-mobile: ?0
  -   sec-ch-ua-platform: "Linux"

  225 |             // server; we pass the request to the server the immediately.
  226 |             result: (async () => {
> 227 |               const originalResponse = await page.request.fetch(request, {
      |                                                           ^
  228 |                 maxRedirects: 0,
  229 |               })
  230 |

  at fetch (lib/router-act.ts:227:59)
  at lib/router-act.ts:245:13
  at routeHandler (lib/router-act.ts:257:7)

@eps1lon eps1lon force-pushed the sebbie/01-29-ensure_license.md_is_included_in_vendored_packages branch from 441531c to 17fea77 Compare January 29, 2026 00:38
@eps1lon eps1lon force-pushed the sebbie/01-29-ensure_license.md_is_included_in_vendored_packages branch from 17fea77 to 632253a Compare January 29, 2026 00:58
Comment on lines +12 to +14
'LICENSE.md',
'License.md',
'license.md',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤡

@eps1lon eps1lon changed the title Ensure LICENSE.md is included in vendored packages Ensure .md licenses are included in vendored packages Jan 29, 2026
@eps1lon eps1lon enabled auto-merge (squash) January 29, 2026 01:54
@eps1lon eps1lon merged commit 242207f into canary Jan 29, 2026
281 of 290 checks passed
@eps1lon eps1lon deleted the sebbie/01-29-ensure_license.md_is_included_in_vendored_packages branch January 29, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants