Turbopack: fix tracking modifications for transient and data #89228
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextjs-bot
added
created-by: Turbopack team
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lukesandberg
approved these changes
Jan 29, 2026
Contributor
lukesandberg
left a comment
lukesandberg
left a comment
There was a problem hiding this comment.
@lukesandberg approved this PR from Slack with Graphite
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
|
Thank you for your favor |
1 similar comment
|
Thank you for your favor |
Member
lukesandberg
added a commit
that referenced
this pull request
Jan 29, 2026
… to more structurally prevent bugs like what was fixed in [#89228](#89228) * generate flags accessors using the same pattern as normal accessors * correctly handle category when encoding/decoding Previously a number of things were special cased for flags since they originally all happened to be `transient` or `meta`, but that is no longer true
lukesandberg
added a commit
that referenced
this pull request
Jan 29, 2026
… to more structurally prevent bugs like what was fixed in [#89228](#89228) * generate flags accessors using the same pattern as normal accessors * correctly handle category when encoding/decoding Previously a number of things were special cased for flags since they originally all happened to be `transient` or `meta`, but that is no longer true
lukesandberg
added a commit
that referenced
this pull request
Jan 30, 2026
… to more structurally prevent bugs like what was fixed in [#89228](#89228) * generate flags accessors using the same pattern as normal accessors * correctly handle category when encoding/decoding Previously a number of things were special cased for flags since they originally all happened to be `transient` or `meta`, but that is no longer true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
track modifications on the correct category