Skip to content

Turbopack: Move PrettyPrintError to turbo_tasks and add tests #89280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sokra merged 3 commits into from
Feb 2, 2026
Merged

Turbopack: Move PrettyPrintError to turbo_tasks and add tests #89280

sokra merged 3 commits into from
Feb 2, 2026
+511 −38

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 30, 2026 •
edited
Loading

What?

Move the error printing logic to turbo_tasks and add test cases for it

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 30, 2026
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 30, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra mentioned this pull request Jan 30, 2026
Merged
@sokra sokra changed the title Move PrettyPrintError to turbo_tasks Move PrettyPrintError to turbo_tasks and add test Jan 30, 2026
@sokra sokra changed the title Move PrettyPrintError to turbo_tasks and add test Turbopack: Move PrettyPrintError to turbo_tasks and add tests Jan 30, 2026
@sokra sokra marked this pull request as ready for review January 30, 2026 08:27
@sokra sokra requested a review from mischnic January 30, 2026 08:28
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 30, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ✓ ▁▁█▁▁
Cold (Ready in log) 444ms 444ms ✓ ▁▂█▁▂
Cold (First Request) 813ms 820ms ✓ ▁▂█▁▅
Warm (Listen) 456ms 456ms ✓ ▁▁█▁▁
Warm (Ready in log) 441ms 443ms ✓ ▁▁█▁▁
Warm (First Request) 347ms 350ms ✓ ▁▂█▂▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ✓ ██▁█▁
Cold (Ready in log) 437ms 438ms ✓ █▆▆▇▅
Cold (First Request) 1.751s 1.743s ✓ ▄▄▃▅▃
Warm (Listen) 456ms 456ms ✓ ▅▁▅▅█
Warm (Ready in log) 437ms 438ms ✓ ▆▅▄▅▄
Warm (First Request) 1.742s 1.755s ✓ ▄▄▃▅▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.024s 3.976s ✓ ▁▃█▂▁
Cached Build 4.024s 4.000s ✓ ▁▃█▂▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.691s 13.716s ✓ ▁▂▁▄▂
Cached Build 13.829s 13.786s ✓ ▂▂▁▄▁
node_modules Size 464 MB 464 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **434 kB** → **434 kB** ✅ -11 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 763 B 770 B ✓
Total 763 B 770 B ⚠️ +7 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B ✓
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 54.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 254 B ✓
main-HASH.js gzip 39 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.52 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 55.2 kB -
Total 228 kB 228 kB ⚠️ +671 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 248 kB 249 kB ✓
Total 375 kB 375 kB ⚠️ +135 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 614 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 33 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.6 kB 34.8 kB ⚠️ +196 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 732 B 736 B ✓
Total 732 B 736 B ⚠️ +4 B
Build Cache
Canary PR Change
0.pack gzip 3.8 MB 3.81 MB 🔴 +12.2 kB (+0%)
index.pack gzip 104 kB 102 kB 🟢 1.76 kB (-2%)
index.pack.old gzip 102 kB 102 kB ✓
Total 4 MB 4.01 MB ⚠️ +11.3 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 311 kB 311 kB ✓
app-page-exp..prod.js gzip 166 kB 166 kB ✓
app-page-tur...dev.js gzip 311 kB 311 kB ✓
app-page-tur..prod.js gzip 166 kB 166 kB ✓
app-page-tur...dev.js gzip 308 kB 308 kB ✓
app-page-tur..prod.js gzip 164 kB 164 kB ✓
app-page.run...dev.js gzip 308 kB 308 kB ✓
app-page.run..prod.js gzip 164 kB 164 kB ✓
app-route-ex...dev.js gzip 70.4 kB 70.4 kB ✓
app-route-ex..prod.js gzip 48.9 kB 48.9 kB ✓
app-route-tu...dev.js gzip 70.4 kB 70.4 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70 kB 70 kB ✓
app-route-tu..prod.js gzip 48.7 kB 48.7 kB ✓
app-route.ru...dev.js gzip 70 kB 70 kB ✓
app-route.ru..prod.js gzip 48.7 kB 48.7 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.1 kB 43.1 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.1 kB 43.1 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.4 kB 52.4 kB ✓
pages-turbo...prod.js gzip 39.4 kB 39.4 kB ✓
pages.runtim...dev.js gzip 52.4 kB 52.4 kB ✓
pages.runtim..prod.js gzip 39.3 kB 39.3 kB ✓
server.runti..prod.js gzip 62.5 kB 62.5 kB ✓
Total 2.77 MB 2.77 MB ⚠️ +3 B

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing sokra/pretty-print-error (e8f6a23) with canary (ef6ac79)

Summary

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sokra sokra force-pushed the sokra/task-cache-stats-details branch from 2b58d7e to a3bdc37 Compare January 30, 2026 13:30
@sokra sokra force-pushed the sokra/pretty-print-error branch 2 times, most recently from 50f8e9f to 5f0df7a Compare January 30, 2026 14:50
@sokra sokra mentioned this pull request Jan 30, 2026
Draft
@sokra sokra force-pushed the sokra/task-cache-stats-details branch from a3bdc37 to 67c30f9 Compare January 30, 2026 15:26
@sokra sokra force-pushed the sokra/pretty-print-error branch from 5f0df7a to 1332f0e Compare January 30, 2026 15:26
mischnic
mischnic reviewed Jan 30, 2026
View reviewed changes
@sokra sokra changed the base branch from sokra/task-cache-stats-details to graphite-base/89280 January 30, 2026 17:58
@sokra sokra force-pushed the graphite-base/89280 branch from 67c30f9 to f7e3314 Compare January 30, 2026 17:59
@sokra sokra force-pushed the sokra/pretty-print-error branch from de64265 to 07a5442 Compare January 30, 2026 17:59
@graphite-app graphite-app bot changed the base branch from graphite-base/89280 to canary January 30, 2026 17:59
@sokra sokra force-pushed the sokra/pretty-print-error branch from 07a5442 to 062bfa0 Compare January 30, 2026 17:59
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 30, 2026 •
edited
Loading

Tests Passed

@sokra sokra force-pushed the sokra/pretty-print-error branch from 062bfa0 to e8f6a23 Compare January 31, 2026 00:29
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 31, 2026 •
edited by sokra
Loading

Merge activity

  • Jan 31, 12:30 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Feb 2, 7:56 AM UTC: @sokra merged this pull request with Graphite.

@sokra sokra merged commit b0facee into canary Feb 2, 2026
288 of 292 checks passed
@sokra sokra deleted the sokra/pretty-print-error branch February 2, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischnic mischnic mischnic approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sokra @nextjs-bot @mischnic