Skip to content

Unify runInSequentialTasks across all sequential task work#89978

Merged
gnoff merged 1 commit intocanaryfrom
jstory/cleanup-sequential-task-rendering
Feb 18, 2026
Merged

Unify runInSequentialTasks across all sequential task work#89978
gnoff merged 1 commit intocanaryfrom
jstory/cleanup-sequential-task-rendering

Conversation

@gnoff
Copy link
Contributor

@gnoff gnoff commented Feb 13, 2026 •
edited
Loading

Stacked on #90065

The older methods were so close in function to runInSequentialTasks we've now unified the interface and use it consistently everywhere.

@gnoff gnoff requested a review from lubieowoce February 13, 2026 21:31
@gnoff gnoff mentioned this pull request Feb 13, 2026
Closed
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 13, 2026 •
edited
Loading

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 13, 2026 •
edited
Loading

Stats from current PR

🟢 1 improvement

Metric Canary PR Change Trend
node_modules Size 473 MB 472 MB 🟢 105 kB (0%) ▁▁▁▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms ✓ ▁▁▁▁▁
Cold (Ready in log) 441ms 444ms ✓ ▁▂▂▁▂
Cold (First Request) 894ms 901ms ✓ ▁▆▃▂▅
Warm (Listen) 456ms 456ms ✓ ▁▁▂▂▁
Warm (Ready in log) 443ms 441ms ✓ ▁▁▂▁▁
Warm (First Request) 355ms 350ms ✓ ▁▂▃▂▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 434ms 436ms ✓ ▁▃▃▁▃
Cold (First Request) 1.901s 1.913s ✓ ▁▂▂▁▂
Warm (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Warm (Ready in log) 435ms 435ms ✓ ▁▃▃▁▃
Warm (First Request) 1.927s 1.922s ✓ ▁▂▂▁▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.151s 4.116s ✓ ▁▁▄▄▁
Cached Build 4.188s 4.124s ✓ ▁▁▄▃▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.893s 13.860s ✓ ▁▁▁▁▁
Cached Build 13.924s 14.003s ✓ ▁▁▁▁▁
node_modules Size 473 MB 472 MB 🟢 105 kB (0%) ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **398 kB** → **398 kB** ✅ -4 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 756 B 765 B 🔴 +9 B (+1%)
Total 756 B 765 B ⚠️ +9 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 452 B ✓
Total 450 B 452 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 57 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 253 B 🟢 3 B (-1%)
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.53 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 57.8 kB -
Total 231 kB 231 kB ⚠️ +725 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.5 kB 2.5 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -2 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 125 kB ✓
page.js gzip 250 kB 250 kB ✓
Total 376 kB 376 kB ⚠️ +200 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 614 B 614 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.6 kB 43.7 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.2 kB 45.3 kB ⚠️ +107 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 3.89 MB 3.9 MB 🔴 +9.76 kB (+0%)
index.pack gzip 104 kB 103 kB 🟢 1.4 kB (-1%)
index.pack.old gzip 103 kB 103 kB ✓
Total 4.1 MB 4.11 MB ⚠️ +8.48 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 316 kB 316 kB ✓
app-page-exp..prod.js gzip 168 kB 168 kB ✓
app-page-tur...dev.js gzip 316 kB 316 kB ✓
app-page-tur..prod.js gzip 168 kB 168 kB ✓
app-page-tur...dev.js gzip 312 kB 312 kB ✓
app-page-tur..prod.js gzip 166 kB 166 kB ✓
app-page.run...dev.js gzip 313 kB 313 kB ✓
app-page.run..prod.js gzip 166 kB 166 kB ✓
app-route-ex...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-ex..prod.js gzip 49.1 kB 49.1 kB ✓
app-route-tu...dev.js gzip 70.6 kB 70.6 kB ✓
app-route-tu..prod.js gzip 49.1 kB 49.1 kB ✓
app-route-tu...dev.js gzip 70.1 kB 70.1 kB ✓
app-route-tu..prod.js gzip 48.9 kB 48.9 kB ✓
app-route.ru...dev.js gzip 70.1 kB 70.1 kB ✓
app-route.ru..prod.js gzip 48.8 kB 48.8 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.5 kB 52.5 kB ✓
pages-turbo...prod.js gzip 38.4 kB 38.4 kB ✓
pages.runtim...dev.js gzip 52.5 kB 52.5 kB ✓
pages.runtim..prod.js gzip 38.4 kB 38.4 kB ✓
server.runti..prod.js gzip 63.5 kB 63.5 kB ✓
Total 2.8 MB 2.8 MB ✅ -647 B
📝 Changed Files (10 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • pages-api.runtime.dev.js
  • pages.runtime.dev.js
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js 
failed to diff
pages-api.runtime.dev.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

@gnoff gnoff force-pushed the jstory/cleanup-task-pipelining branch from 193522d to 4059118 Compare February 13, 2026 21:53
@gnoff gnoff force-pushed the jstory/cleanup-sequential-task-rendering branch from f823908 to e2b4c1e Compare February 13, 2026 21:54
@gnoff gnoff force-pushed the jstory/cleanup-task-pipelining branch from 4059118 to deb84d0 Compare February 13, 2026 22:34
@gnoff gnoff force-pushed the jstory/cleanup-sequential-task-rendering branch from e2b4c1e to 494fcfb Compare February 13, 2026 22:38
@gnoff gnoff mentioned this pull request Feb 13, 2026
Merged
@gnoff gnoff force-pushed the jstory/cleanup-task-pipelining branch 2 times, most recently from 0ad577d to 61ec827 Compare February 16, 2026 17:45
@gnoff gnoff force-pushed the jstory/cleanup-sequential-task-rendering branch from 494fcfb to ff08e12 Compare February 16, 2026 17:49
@gnoff gnoff force-pushed the jstory/cleanup-task-pipelining branch from 61ec827 to 5ba1abc Compare February 16, 2026 20:13
@gnoff gnoff force-pushed the jstory/cleanup-sequential-task-rendering branch 2 times, most recently from c4ef86b to 001140b Compare February 16, 2026 21:08
Base automatically changed from jstory/cleanup-task-pipelining to jstory/use-stage-controller-for-prerender February 16, 2026 22:18
@gnoff gnoff force-pushed the jstory/use-stage-controller-for-prerender branch from 832b6e2 to e98dc62 Compare February 16, 2026 22:51
Base automatically changed from jstory/use-stage-controller-for-prerender to canary February 17, 2026 00:13
@gnoff gnoff force-pushed the jstory/cleanup-sequential-task-rendering branch 3 times, most recently from 213cc10 to 5fcecfc Compare February 17, 2026 21:56
vercel[bot]
vercel bot reviewed Feb 17, 2026
View reviewed changes
@gnoff
Unify runInSequentialTasks across all sequential task work
de7e2df 
The older methods were so close in function to runInSequentialTasks we've now unified the interface and use it consistently everywhere.
@gnoff gnoff force-pushed the jstory/cleanup-sequential-task-rendering branch from 5fcecfc to de7e2df Compare February 17, 2026 23:22
@gnoff gnoff merged commit 715103a into canary Feb 18, 2026
285 of 287 checks passed
@gnoff gnoff deleted the jstory/cleanup-sequential-task-rendering branch February 18, 2026 00:33
gnoff added a commit that referenced this pull request Feb 18, 2026
@gnoff
Cleanup all stage promises on abort (#89984)
78f13e0 
Stacked on #89978

When the AbortSignal passed to the StagedRenderingController is aborted
there is some logic to potentially abort any unresolved stage promises.
Semantically anything we have a render with a stage controller that is
aborted we must ensure no stage promises are left in a perpetually
pending state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@lubieowoce lubieowoce lubieowoce approved these changes

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gnoff @nextjs-bot @lubieowoce