[ci] Stop using Turbopack tests in native binary build cache keys#90449
Merged
[ci] Stop using Turbopack tests in native binary build cache keys#90449
Conversation
|
Cursor Agent can help with this pull request. Just |
eps1lon
changed the title
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Collaborator
Failing test suitesCommit: ac5a9b4 | About building and testing Next.js
Expand output● LRU disk eviction › should promote entries on get() to prevent eviction |
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **399 kB** → **399 kB** ✓80 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
Test fixture directories under turbopack/crates/*/tests contain node_modules and other non-source files that cause spurious cache invalidation for next-swc build tasks. Add negation patterns to exclude them from all tasks in packages/next-swc/turbo.json. Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>
The test exclusion should only apply to binary build tasks. Tasks that compile or analyze test code (rust-check-fmt, rust-check-clippy, rust-check-napi, test-cargo-unit) need test files as inputs to correctly invalidate their cache when tests change. Co-authored-by: Sebastian "Sebbie" Silbermann <silbermann.sebastian@gmail.com>
eps1lon
force-pushed
the
cursor/turbopack-tests-input-exclusion-c90d
branch
from
d3a26fe to
ac5a9b4
Compare
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mischnic
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests can include node_modules that cause cache invalidations in windows runners. They're also not contributing to the binaries and should be save to exclude.
Now windows jobs all use the same binary created in build-native-windows:
2d683f1c4730153a2d683f1c4730153a2d683f1c4730153a2d683f1c4730153aSlack Thread