You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ended up having to keep the build id in _next/data routes anyway (and made the id a constant if skew protection is enabled). This was because it was utterly impossible to change the routes from _next/data/:buildId/* to _next/data/* in the builder in a backwards-compatible way.
So there is no need to remove the build id from _next/static here either. It just makes testing a huge pain because the paths keep changing
app dir client cache with parallel routes > prefetch={true} > should re-use the cache for the full page, only for 5 mins (DD)
Expand output
● app dir client cache with parallel routes › prefetch={true} › should re-use the cache for the full page, only for 5 mins
thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
50 | }
51 |
> 52 | const result = Reflect.apply(target, thisArg, args)
| ^
53 | return typeof result === 'function' ? wrapJestTestFn(result) : result
54 | },
55 | get(target, prop, receiver) {
at Object.apply (lib/e2e-utils/index.ts:52:30)
at it (e2e/app-dir/app-client-cache/client-cache.parallel-routes.test.ts:56:5)
at describe (e2e/app-dir/app-client-cache/client-cache.parallel-routes.test.ts:30:3)
at Object.describe (e2e/app-dir/app-client-cache/client-cache.parallel-routes.test.ts:7:1)
The reason will be displayed to describe this comment to others. Learn more.
Additional Suggestion:
The deploymentId: string property remains as a required field in TurbopackManifestLoader's constructor type parameter despite being completely unused after the PR's cleanup, forcing callers to pass a value that is silently ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two steps forward, one step back
Reverts #88641 and #88806
I ended up having to keep the build id in
_next/dataroutes anyway (and made the id a constant if skew protection is enabled). This was because it was utterly impossible to change the routes from_next/data/:buildId/*to_next/data/*in the builder in a backwards-compatible way.So there is no need to remove the build id from
_next/statichere either. It just makes testing a huge pain because the paths keep changing