Skip to content

Less dynamic pages manifest path#90581

Merged
mischnic merged 2 commits intocanaryfrom
mischnic/less-dynamic-pages-manifest-path
Feb 26, 2026
Merged

Less dynamic pages manifest path#90581
mischnic merged 2 commits intocanaryfrom
mischnic/less-dynamic-pages-manifest-path

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Feb 26, 2026

Two steps forward, one step back

Reverts #88641 and #88806

I ended up having to keep the build id in _next/data routes anyway (and made the id a constant if skew protection is enabled). This was because it was utterly impossible to change the routes from _next/data/:buildId/* to _next/data/* in the builder in a backwards-compatible way.

So there is no need to remove the build id from _next/static here either. It just makes testing a huge pain because the paths keep changing

Copy link
Member Author

mischnic commented Feb 26, 2026

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 26, 2026

Failing test suites

Commit: 2ccaa11 | About building and testing Next.js

pnpm test-deploy test/e2e/app-dir/app-client-cache/client-cache.original.test.ts (job)

  • app dir client cache semantics (30s/5min) > prefetch={undefined} - default > should refetch the full page after 5 mins (DD)
Expand output

● app dir client cache semantics (30s/5min) › prefetch={undefined} - default › should refetch the full page after 5 mins

page.waitForSelector: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('#loading') to be visible

  519 |
  520 |     return this.startChain(async () => {
> 521 |       const el = await page.waitForSelector(selector, {
      |                             ^
  522 |         timeout,
  523 |         state,
  524 |       })

  at waitForSelector (lib/browsers/playwright.ts:521:29)
  at Object.<anonymous> (e2e/app-dir/app-client-cache/client-cache.original.test.ts:387:34)
  at Proxy._chain (lib/browsers/playwright.ts:651:23)
  at Proxy._chain (lib/browsers/playwright.ts:632:17)
  at Proxy.startChain (lib/browsers/playwright.ts:520:17)
  at Object.waitForElementByCss (e2e/app-dir/app-client-cache/client-cache.original.test.ts:390:12)
  at Proxy._chain (lib/browsers/playwright.ts:651:23)
  at Proxy._chain (lib/browsers/playwright.ts:627:17)
  at Proxy.continueChain (lib/browsers/playwright.ts:433:17)
  at Object.text (e2e/app-dir/app-client-cache/client-cache.original.test.ts:391:12)

pnpm test-deploy test/e2e/app-dir/segment-cache/basic/segment-cache-basic.test.ts (job)

  • segment cache (basic tests) > refreshes page segments when navigating to the exact same URL as the current location (DD)
Expand output

● segment cache (basic tests) › refreshes page segments when navigating to the exact same URL as the current location

expect(received).not.toBe(expected) // Object.is equality

Expected: not "194678393"

  317 |     ])
  318 |     const randomNumber2 = await readRandomNumberFromPage()
> 319 |     expect(randomNumber2).not.toBe(randomNumber)
      |                               ^
  320 |
  321 |     // Navigating to a different hash should *not* refresh the page
  322 |     await act(async () => {

  at Object.toBe (e2e/app-dir/segment-cache/basic/segment-cache-basic.test.ts:319:31)

pnpm test-deploy test/e2e/app-dir/app-client-cache/client-cache.parallel-routes.test.ts (job)

  • app dir client cache with parallel routes > prefetch={true} > should re-use the cache for the full page, only for 5 mins (DD)
Expand output

● app dir client cache with parallel routes › prefetch={true} › should re-use the cache for the full page, only for 5 mins

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  50 |       }
  51 |
> 52 |       const result = Reflect.apply(target, thisArg, args)
     |                              ^
  53 |       return typeof result === 'function' ? wrapJestTestFn(result) : result
  54 |     },
  55 |     get(target, prop, receiver) {

  at Object.apply (lib/e2e-utils/index.ts:52:30)
  at it (e2e/app-dir/app-client-cache/client-cache.parallel-routes.test.ts:56:5)
  at describe (e2e/app-dir/app-client-cache/client-cache.parallel-routes.test.ts:30:3)
  at Object.describe (e2e/app-dir/app-client-cache/client-cache.parallel-routes.test.ts:7:1)

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

The deploymentId: string property remains as a required field in TurbopackManifestLoader's constructor type parameter despite being completely unused after the PR's cleanup, forcing callers to pass a value that is silently ignored.

Fix on Vercel

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 26, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ▁▁▁▁▁
Cold (Ready in log) 438ms 438ms ▂▂▁▂▂
Cold (First Request) 1.258s 1.230s ▄▄▁▄▄
Warm (Listen) 456ms 457ms ▁▁▁▁▁
Warm (Ready in log) 442ms 442ms ▁▁▁▁▁
Warm (First Request) 346ms 342ms ▁▁▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁▁█▁
Cold (Ready in log) 436ms 436ms ▆▆▅▆▅
Cold (First Request) 1.914s 1.915s ▅▄▅▄▄
Warm (Listen) 456ms 456ms ▁▅▅▅▅
Warm (Ready in log) 435ms 435ms █▇▆▇▅
Warm (First Request) 1.950s 1.929s ▅▅▄▄▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.975s 3.968s ▁▁▁▁▁
Cached Build 4.042s 4.016s ▁▁▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.953s 13.911s ▂▂▂▂▁
Cached Build 14.050s 14.057s ▂▂▂▂▁
node_modules Size 475 MB 475 MB ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **400 kB** → **400 kB** ✅ -13 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 764 B 764 B
Total 764 B 764 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 452 B
Total 451 B 452 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 58.3 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 255 B 254 B
main-HASH.js gzip 39.1 kB 39.1 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 59 kB -
Total 232 kB 233 kB ⚠️ +720 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.5 kB 2.5 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.97 kB ✅ -2 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB
page.js gzip 254 kB 254 kB
Total 379 kB 379 kB ⚠️ +308 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 613 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 43.5 kB 43.9 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 45.1 kB 45.5 kB ⚠️ +346 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.01 MB 4.02 MB 🔴 +7.09 kB (+0%)
index.pack gzip 103 kB 104 kB 🔴 +1.67 kB (+2%)
index.pack.old gzip 102 kB 103 kB
Total 4.22 MB 4.23 MB ⚠️ +9.26 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 320 kB 320 kB
app-page-exp..prod.js gzip 170 kB 170 kB
app-page-tur...dev.js gzip 319 kB 319 kB
app-page-tur..prod.js gzip 169 kB 169 kB
app-page-tur...dev.js gzip 316 kB 316 kB
app-page-tur..prod.js gzip 168 kB 168 kB
app-page.run...dev.js gzip 316 kB 316 kB
app-page.run..prod.js gzip 168 kB 168 kB
app-route-ex...dev.js gzip 70.8 kB 70.8 kB
app-route-ex..prod.js gzip 49.2 kB 49.2 kB
app-route-tu...dev.js gzip 70.8 kB 70.8 kB
app-route-tu..prod.js gzip 49.2 kB 49.2 kB
app-route-tu...dev.js gzip 70.4 kB 70.4 kB
app-route-tu..prod.js gzip 49 kB 49 kB
app-route.ru...dev.js gzip 70.4 kB 70.4 kB
app-route.ru..prod.js gzip 49 kB 49 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB
pages-turbo....dev.js gzip 52.5 kB 52.5 kB
pages-turbo...prod.js gzip 38.5 kB 38.5 kB
pages.runtim...dev.js gzip 52.5 kB 52.5 kB
pages.runtim..prod.js gzip 38.4 kB 38.4 kB
server.runti..prod.js gzip 62 kB 62 kB
Total 2.82 MB 2.82 MB
📎 Tarball URL
next@https://vercel-packages.vercel.app/next/prs/90581/next

@mischnic mischnic marked this pull request as ready for review February 26, 2026 11:53
@mischnic mischnic requested a review from a team February 26, 2026 13:21
@mischnic mischnic merged commit 17033ca into canary Feb 26, 2026
439 of 486 checks passed
@mischnic mischnic deleted the mischnic/less-dynamic-pages-manifest-path branch February 26, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants