Update the link in the request body size warning to a non-redirecting, version-specific URL#90772
Open
Kevin-Xi wants to merge 1 commit intovercel:canaryfrom
Open
Update the link in the request body size warning to a non-redirecting, version-specific URL#90772Kevin-Xi wants to merge 1 commit intovercel:canaryfrom
Kevin-Xi wants to merge 1 commit intovercel:canaryfrom
Conversation
…, version-specific URL
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
| console.warn( | ||
| // TODO(jiwon): Update this document link | ||
| `Request body exceeded ${bytes.format(bodySizeLimit)}${urlInfo}. Only the first ${bytes.format(bodySizeLimit)} will be available unless configured. See https://nextjs.org/docs/app/api-reference/config/next-config-js/middlewareClientMaxBodySize for more details.` | ||
| `Request body exceeded ${bytes.format(bodySizeLimit)}${urlInfo}. Only the first ${bytes.format(bodySizeLimit)} will be available unless configured. See https://nextjs.org/docs/15/app/api-reference/config/next-config-js/middlewareClientMaxBodySize for more details.` |
Contributor
There was a problem hiding this comment.
Suggested change
| `Request body exceeded ${bytes.format(bodySizeLimit)}${urlInfo}. Only the first ${bytes.format(bodySizeLimit)} will be available unless configured. See https://nextjs.org/docs/15/app/api-reference/config/next-config-js/middlewareClientMaxBodySize for more details.` | |
| `Request body exceeded ${bytes.format(bodySizeLimit)}${urlInfo}. Only the first ${bytes.format(bodySizeLimit)} will be available unless configured. See https://nextjs.org/docs/app/api-reference/config/next-config-js/proxyClientMaxBodySize for more details.` |
Warning message links to versioned v15 docs for the deprecated middlewareClientMaxBodySize config instead of the current proxyClientMaxBodySize docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when v15 users encounter this warning and click the link (https://nextjs.org/docs/app/api-reference/config/next-config-js/middlewareClientMaxBodySize), they are redirected to the v16
proxyClientMaxBodySizepage (https://nextjs.org/docs/app/api-reference/config/next-config-js/proxyClientMaxBodySize).They also cannot switch the doc version back to v15 to reach the
middlewareClientMaxBodySizepage. Switching from the v16proxyClientMaxBodySizepage to v15 does not redirect to the correspondingmiddlewareClientMaxBodySizepage.As a result, users must first notice that the link was redirected and then manually locate the correct page. This is confusing.